Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate the new explain test setup into the new test action system #1243

Closed
shahzadlone opened this issue Mar 28, 2023 · 0 comments · Fixed by #1545
Closed

Integrate the new explain test setup into the new test action system #1243

shahzadlone opened this issue Mar 28, 2023 · 0 comments · Fixed by #1545
Assignees
@shahzadlone
Labels
area/testing Related to any test or testing suite
Milestone
DefraDB v0.6

Comments

@shahzadlone
Copy link
Member

shahzadlone commented Mar 28, 2023 •
edited
Loading

2 things happened to our testing frameworks:

The new action based setup is not as rigid as our previous setup which couldn't be extended, so should integrate the new explain testing framework as an action of the new general integration testing setup.

If this is done before the conversion of old explain tests, would help save time having to convert these tests twice.

Side Notes:
for explain(type:execute) tests, introduce a way to omit Elapsed Time like metrics that will vary every execution (i.e. can't assert).
@shahzadlone shahzadlone added the area/testing Related to any test or testing suite label Mar 28, 2023
@shahzadlone shahzadlone added this to the DefraDB v0.5.1 milestone Mar 28, 2023
@shahzadlone shahzadlone self-assigned this Mar 28, 2023
@shahzadlone shahzadlone mentioned this issue Mar 29, 2023
Merged
4 tasks
@shahzadlone shahzadlone mentioned this issue Apr 20, 2023
Closed
24 tasks
@fredcarle fredcarle modified the milestones: DefraDB v0.5.1, DefraDB v0.6 May 9, 2023
@shahzadlone shahzadlone mentioned this issue May 29, 2023
Merged
shahzadlone added a commit that referenced this issue May 29, 2023
@shahzadlone
test(i): Convert simple explain test to new explain setup (#1543)
d19bf85 
## Relevant issue(s)
- Resolves #953

## Description
This PR is the last PR that finishes all old explain test conversions to
the new explain setup. This PR converts the simple explain tests and
reorganizes some fixtures.

Note: After this PR is merged, this
(#1243) can also be
resolved in a follow-up PR.
@shahzadlone shahzadlone mentioned this issue May 29, 2023
Merged
6 tasks
shahzadlone added a commit that referenced this issue May 30, 2023
@shahzadlone
test(i): Integrate explain tests into test action system (#1545)
43857bb 
Resolves #1243

## Description:
- [x] Integrates the new explain test setup with the new testing with
action based setup.
- [x] Converts all simple explain tests.
- [x] Converts all default explain tests.
- [x] Converts all execute explain tests.
- [x] Removes the documents for default and simple tests as they aren't
worth maintaining (it doesn't effect simple explain testing).
- [x] Fixed a test that was being omitted due to it's file not having
the extension "*_test.go".
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
test(i): Convert simple explain test to new explain setup (sourcenetw…
cb75148 
…ork#1543)

## Relevant issue(s)
- Resolves sourcenetwork#953

## Description
This PR is the last PR that finishes all old explain test conversions to
the new explain setup. This PR converts the simple explain tests and
reorganizes some fixtures.

Note: After this PR is merged, this
(sourcenetwork#1243) can also be
resolved in a follow-up PR.
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
test(i): Integrate explain tests into test action system (sourcenetwo…
dc2bacc 
…rk#1545)

Resolves sourcenetwork#1243

## Description:
- [x] Integrates the new explain test setup with the new testing with
action based setup.
- [x] Converts all simple explain tests.
- [x] Converts all default explain tests.
- [x] Converts all execute explain tests.
- [x] Removes the documents for default and simple tests as they aren't
worth maintaining (it doesn't effect simple explain testing).
- [x] Fixed a test that was being omitted due to it's file not having
the extension "*_test.go".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzadlone shahzadlone

Labels
area/testing Related to any test or testing suite
Projects
None yet
Milestone
DefraDB v0.6
Development

Successfully merging a pull request may close this issue.

test(i): Integrate explain tests into test action system shahzadlone/defradb
2 participants
@fredcarle @shahzadlone