test(i): Convert simple explain test to new explain setup #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzadlone
added
area/testing
shahzadlone
changed the title
- Only keep the required fixtured within each test package. - Move the common schema, and runner function to one level above.
shahzadlone
force-pushed
the
test/refactor-simple-explain-tests-to-new-setup
branch
from
6d4d767
to
593e89c
Compare
shahzadlone
force-pushed
the
test/refactor-simple-explain-tests-to-new-setup
branch
from
593e89c
to
c11d346
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1543 +/- ##
===========================================
+ Coverage 72.10% 72.19% +0.09%
===========================================
Files 185 185
Lines 18374 18374
===========================================
+ Hits 13249 13266 +17
+ Misses 4076 4064 -12
+ Partials 1049 1044 -5 |
AndrewSisley
approved these changes
May 29, 2023
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…ork#1543) ## Relevant issue(s) - Resolves sourcenetwork#953 ## Description This PR is the last PR that finishes all old explain test conversions to the new explain setup. This PR converts the simple explain tests and reorganizes some fixtures. Note: After this PR is merged, this (sourcenetwork#1243) can also be resolved in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Description
This PR is the last PR that finishes all old explain test conversions to the new explain setup. This PR converts the simple explain tests and reorganizes some fixtures.
Note: After this PR is merged, this (#1243) can also be resolved in a follow-up PR.