fmt-v9 compatibility #376
Merged
fmt-v9 compatibility #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DmitriyKorchemkin thanks for this PR. I'm consider this a workaround, but a long term solution. Nevertheless, I'll merge it in to unbreak folks - so the sophus 22.10 release will be able to support libfmt 9.0. For future versions of Sophus, I'm contemplating on using fmt::formatter instead of ostream overloads. |
|
Very good！ |
NikolausDemmel
added a commit
to NikolausDemmel/homebrew-core
that referenced
this pull request
Oct 12, 2022
Sophus compilation was broken with libfmt version >= 9.0. As a workaround the dependency was removed and "basic logging" enabled: - Homebrew#108156 - Homebrew#110137 The sophus formula was recently updated to version 22.10, which fixed the compatibility with libfmt version >= 9.0: - strasdat/Sophus#376 - Homebrew#11286 This PR removes the workaround.
6 tasks
BrewTestBot
pushed a commit
to Homebrew/homebrew-core
that referenced
this pull request
Oct 13, 2022
Sophus compilation was broken with libfmt version >= 9.0. As a workaround the dependency was removed and "basic logging" enabled: - #108156 - #110137 The sophus formula was recently updated to version 22.10, which fixed the compatibility with libfmt version >= 9.0: - strasdat/Sophus#376 - #11286 This PR removes the workaround. Closes #112988. Signed-off-by: Carlo Cabrera <[email protected]> Signed-off-by: BrewTestBot <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libfmtintroduces breaking changes in API starting from v9.0.Multiple types, such as Eigen expressions, templated scalar types were being output via old API that allowed anything
std::ostream<<'able to be output using just an{}format expression and nothing else.Adding a wrapper into
fmt::streamedto all arguments of various macros seems to be the simplest way to preserve behavior similar to one that was available with the previous version oflibfmt