Added "helper" functionality #9
Conversation
This PR enables us to do
````
$this->helper('DependencyInjection')
````
to retrieve special helper classes.
Helper classes can implements `ContainerAwareInterface` to have access
to the container.
Have included a helper for DependecyInjection
| @@ -25,6 +26,31 @@ public function db($type) | |||
| return $this->getDbManager($type); | |||
| } | |||
|
|
|||
| public function helper($name) | |||
| { | |||
| $name = ucfirst($name).'Helper'; | |||
There was a problem hiding this comment.
imo, it's cleaner to put this in the sprintf
|
Not sure if I like it that we create a new instance of the helper each time. This is inconsistent with Console Helpers (which are quite related to these helpers) |
|
Yeah, I can cache that. Might cause problems if helpers are stateful though. |
|
And that's the reason why almost nothing of the console component is statefull |
|
looks ok. i wonder however if it does not mean its time to start using the IcTestBundle thingy, if we need to add code from their bundle here... |
|
Well, the IcTestBundle doesn't support XML schema validation. I just don't want to add a dependency that doesn't "fit"and that we have no control over. The code we add is very simple in anycase, and IcTest doesn't support PhpcrOdm. |
|
we could try to contribute that to IcTestBundle too :-) but anyways, i am ok if you want to merge this, go for it. |
|
@dantleech what is the state of this? should we update the branch and merge, or drop it? |
|
helper functionality +1 |
|
Closing as it's replaced by #33 and we don't need the helper functionality at the moment (and I also don't like the concept of helpers). |
This PR enables us to do
to retrieve special helper classes. It is inspired by the IcBaseTestBundle.
Helper classes can implements
ContainerAwareInterfaceto have accessto the container.
Have included a helper for DependecyInjection to help with schema validation.