-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-v0.43.x] ChildReference status helper functions should support both CustomRuns and Runs #5941
[release-v0.43.x] ChildReference status helper functions should support both CustomRuns and Runs #5941
Conversation
… and Runs fixes tektoncd#5933 I updated `pkg/status` to support `CustomRun`s early in the work for supporting `CustomRun`s in the `PipelineRun` reconciler, but forgot to add back support for `Run`s as well when we moved to the reconciler supporting both, depending on a feature flag. This broke tektoncd/cli#1838. This change brings back support for `Run`s in the status helper functions, alongside the support for `CustomRun`s. Signed-off-by: Andrew Bayer <[email protected]>
/kind bug |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The |
We hit an issue on tektoncd#5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
We hit an issue on tektoncd#5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
We hit an issue on tektoncd#5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
We hit an issue on #5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
We hit an issue on tektoncd#5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
We hit an issue on tektoncd#5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
We hit an issue on tektoncd#5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
We hit an issue on tektoncd#5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
We hit an issue on #5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
We hit an issue on #5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
We hit an issue on #5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
We hit an issue on #5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
/retest |
/lgtm |
/retest |
This is an automated cherry-pick of #5936
/assign vdemeester