[release-v0.43.x] ChildReference status helper functions should support both CustomRuns and Runs #5941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and Runs fixes tektoncd#5933 I updated `pkg/status` to support `CustomRun`s early in the work for supporting `CustomRun`s in the `PipelineRun` reconciler, but forgot to add back support for `Run`s as well when we moved to the reconciler supporting both, depending on a feature flag. This broke tektoncd/cli#1838. This change brings back support for `Run`s in the status helper functions, alongside the support for `CustomRun`s. Signed-off-by: Andrew Bayer <[email protected]>
tekton-robot
added
the
release-note
7 tasks
tekton-robot
added
the
size/L
|
/kind bug |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
The |
abayer
added a commit
to abayer/tektoncd-pipeline
that referenced
this pull request
Jan 4, 2023
We hit an issue on tektoncd#5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
7 tasks
abayer
added a commit
to abayer/tektoncd-pipeline
that referenced
this pull request
Jan 4, 2023
We hit an issue on tektoncd#5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
abayer
added a commit
to abayer/tektoncd-pipeline
that referenced
this pull request
Jan 4, 2023
We hit an issue on tektoncd#5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
tekton-robot
pushed a commit
that referenced
this pull request
Jan 4, 2023
We hit an issue on #5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
tekton-robot
pushed a commit
to tekton-robot/pipeline
that referenced
this pull request
Jan 4, 2023
We hit an issue on tektoncd#5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
tekton-robot
pushed a commit
to tekton-robot/pipeline
that referenced
this pull request
Jan 4, 2023
We hit an issue on tektoncd#5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
tekton-robot
pushed a commit
to tekton-robot/pipeline
that referenced
this pull request
Jan 4, 2023
We hit an issue on tektoncd#5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
tekton-robot
pushed a commit
to tekton-robot/pipeline
that referenced
this pull request
Jan 4, 2023
We hit an issue on tektoncd#5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
tekton-robot
pushed a commit
that referenced
this pull request
Jan 4, 2023
We hit an issue on #5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
tekton-robot
pushed a commit
that referenced
this pull request
Jan 4, 2023
We hit an issue on #5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
tekton-robot
pushed a commit
that referenced
this pull request
Jan 5, 2023
We hit an issue on #5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
tekton-robot
pushed a commit
that referenced
this pull request
Jan 5, 2023
We hit an issue on #5941 due to the golangci-lint installed on the `test-runner` image being upgraded and reporting new issues that weren't encountered at the time of the v0.43.0 release. Ideally, the build tests job should be using the same golangci-lint version as is defined in the Makefile, so let's switch to calling a make target. Signed-off-by: Andrew Bayer <[email protected]>
|
/retest |
|
/lgtm |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #5936
/assign vdemeester