Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.43.x] ChildReference status helper functions should support both CustomRuns and Runs #5941

Merged
merged 1 commit into from
Jan 5, 2023
Merged

[release-v0.43.x] ChildReference status helper functions should support both CustomRuns and Runs #5941

merged 1 commit into from
Jan 5, 2023

Commits on Jan 4, 2023

  1. ChildReference status helper functions should support both CustomRuns… 

    … and Runs

fixes tektoncd#5933

I updated `pkg/status` to support `CustomRun`s early in the work for supporting `CustomRun`s in the `PipelineRun` reconciler, but forgot to add back support for `Run`s as well when we moved to the reconciler supporting both, depending on a feature flag. This broke tektoncd/cli#1838. This change brings back support for `Run`s in the status helper functions, alongside the support for `CustomRun`s.

Signed-off-by: Andrew Bayer <[email protected]>
    @abayer
    abayer authored and tekton-robot committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    333955a View commit details
    Browse the repository at this point in the history