Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use yaml for dummy_diag_publisher config #101

Merged
merged 3 commits into from
Feb 16, 2023

Conversation

asana17
Copy link
Contributor

@asana17 asana17 commented Feb 7, 2023

Signed-off-by: asana17 [email protected]

Related Links:
autowarefoundation/autoware.universe#2840
https://github.com/tier4/autoware_launch/pull/762

I changed the launch of dummy_diag_publisher to use the parameter YAML files instead of the launch XML files.

Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asana17 asana17 merged commit 5d950fc into tier4/universe Feb 16, 2023
@asana17 asana17 deleted the feat/use-yaml-for-dummy-diag-publisher branch February 16, 2023 08:18
tkimura4 added a commit that referenced this pull request Mar 13, 2023
yukkysaito added a commit that referenced this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants