Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mrm_handler): add mrm handler #1215

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Conversation

mkuri
Copy link

@mkuri mkuri commented Mar 28, 2024

Description

Add mrm_handler.

Related links

Tests performed

#1215 (review)

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

TetsuKawa and others added 5 commits March 28, 2024 14:51
* feat: add mrm_handler

Signed-off-by: TetsuKawa <[email protected]>

* style(pre-commit): autofix

Signed-off-by: TetsuKawa <[email protected]>

* modify: update README

Signed-off-by: TetsuKawa <[email protected]>

* feat: refactor isArrivedAtGoal()

Signed-off-by: TetsuKawa <[email protected]>

* modify: fix error massages gramatically.

Signed-off-by: TetsuKawa <[email protected]>

* feat: update the person in charge of the unimplemented parts

Signed-off-by: TetsuKawa <[email protected]>

* modify: fix typo in schema.json

Signed-off-by: TetsuKawa <[email protected]>

* modify: fix copyright

Signed-off-by: TetsuKawa <[email protected]>

* modify: fix mistakes in README

Signed-off-by: TetsuKawa <[email protected]>

* modify: correct a type mistake in README

Signed-off-by: TetsuKawa <[email protected]>

* style(pre-commit): autofix

Signed-off-by: TetsuKawa <[email protected]>

---------

Signed-off-by: TetsuKawa <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Makoto Kurihara <[email protected]>
…tion#6522)

update(mrm_handler, emergency_handler): remove takeover

Signed-off-by: veqcc <[email protected]>
…oundation#6514)

* refactor(mrm_handler): delete control_cmd publish function

Signed-off-by: veqcc <[email protected]>
* feat: add timeouts of request services

Signed-off-by: TetsuKawa <[email protected]>

* style(pre-commit): autofix

* feat: replace define with enum

Signed-off-by: TetsuKawa <[email protected]>

* style(pre-commit): autofix

* modify: renam a function

Signed-off-by: TetsuKawa <[email protected]>

* modify: rename a function

Signed-off-by: TetsuKawa <[email protected]>

* modify: fix functions name at the caller side

Signed-off-by: TetsuKawa <[email protected]>

---------

Signed-off-by: TetsuKawa <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Takagi, Isamu <[email protected]>
Co-authored-by: Ryuta Kambe <[email protected]>
Copy link

@TomohitoAndo TomohitoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed planning simulator works when using mrm_handler with diagnostic_graph_aggregator.

image

@mkuri mkuri merged commit fe0b657 into beta/v0.19.1 Mar 28, 2024
14 of 16 checks passed
@mkuri mkuri deleted the feature/add-mrm-handler branch March 28, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants