Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rtc_manager_rviz_plugin): add rtc manager viewer only #144

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

taikitanaka3
Copy link

Description

add rtc viewer

Related links

autowarefoundation#1936

Tests performed

by psim

Notes for reviewers

test is necessary

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

taikitanaka3 and others added 2 commits October 6, 2022 17:20
* feat: add rtc  manager rviz plugin

Signed-off-by: tanaka3 <[email protected]>

* chore: cosmetic change

Signed-off-by: tanaka3 <[email protected]>

* chore: remove indent

Signed-off-by: tanaka3 <[email protected]>

* feat: add rtc safe unsafe color

Signed-off-by: tanaka3 <[email protected]>

* fix: typo

Signed-off-by: tanaka3 <[email protected]>

* chore: simplify layout

Signed-off-by: tanaka3 <[email protected]>

* feat: update rtc panel

Signed-off-by: tanaka3 <[email protected]>

Signed-off-by: tanaka3 <[email protected]>
Copy link

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taikitanaka3 taikitanaka3 merged commit aee2610 into beta/v0.5.2 Oct 7, 2022
@taikitanaka3 taikitanaka3 deleted the beta/v0.5.2_rtc_manager_viewer_only branch October 7, 2022 05:19
takayuki5168 pushed a commit that referenced this pull request Dec 22, 2022
* feat: add rtc  manager rviz plugin (autowarefoundation#1936)

* feat: add rtc  manager rviz plugin

Signed-off-by: tanaka3 <[email protected]>

* chore: cosmetic change

Signed-off-by: tanaka3 <[email protected]>

* chore: remove indent

Signed-off-by: tanaka3 <[email protected]>

* feat: add rtc safe unsafe color

Signed-off-by: tanaka3 <[email protected]>

* fix: typo

Signed-off-by: tanaka3 <[email protected]>

* chore: simplify layout

Signed-off-by: tanaka3 <[email protected]>

* feat: update rtc panel

Signed-off-by: tanaka3 <[email protected]>

Signed-off-by: tanaka3 <[email protected]>

* feat(rtc_manager_rviz_plugin): down grade to v0.5.2

Signed-off-by: tanaka3 <[email protected]>

Signed-off-by: tanaka3 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants