Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sensing): use autoware_cmake to avoid Boost warning #536

Merged
merged 2 commits into from
May 26, 2023

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented May 26, 2023

Description

autowarefoundation#849 からBoostのwarningが出ているパッケージだけを抜き出して適用

Related Links

https://tier4.atlassian.net/browse/AEAP-488

Tests performed

下記のコマンドでビルドしてsensing以下のパッケージでBoostのwarningが出ないこと

colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --catkin-skip-building-tests --parallel-workers 8 --packages-up-to  $(colcon list --base-path src/autoware/universe/sensing | awk '{print $1}')

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link

@v-nojiri7841-esol v-nojiri7841-esol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

前後のPRの影響により、ビルドエラー発生中。
以下のPRを取り込むことでビルドエラーが解消し、BoostのWarningもなくなることを確認。

以下のPRが取り込まれたあと、リベースが必要。
#535

@h-ohta h-ohta enabled auto-merge (squash) May 26, 2023 08:05
Copy link

@v-nojiri7841-esol v-nojiri7841-esol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

リベース後、ビルドエラーなし、BoostのWarningなしが確認できた。

@h-ohta h-ohta merged commit 7507f0e into beta/v0.3.16 May 26, 2023
@h-ohta h-ohta deleted the feat/autoware_cmake_sensing branch May 26, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants