Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(system): use autoware_cmake to avoid Boost warning #537

Closed
wants to merge 3 commits into from

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented May 26, 2023

Description

Related Links

https://tier4.atlassian.net/browse/AEAP-488

Tests performed

下記のコマンドでビルドしてsystem以下のパッケージでBoostのwarningが出ないこと

colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --catkin-skip-building-tests --parallel-workers 8 --packages-up-to  $(colcon list --base-path src/autoware/universe/system | awk '{print $1}')

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta
Copy link
Author

h-ohta commented May 26, 2023

ビルドエラーが出ているので確認中

ito-san and others added 2 commits May 26, 2023 17:11
* fix(system_monitor): fix truncation warning in strncpy

* Use std::string constructor to copy char array

* Fixed typo
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.3.16@7507f0e). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@              Coverage Diff               @@
##             beta/v0.3.16    #537   +/-   ##
==============================================
  Coverage                ?   0.00%           
==============================================
  Files                   ?      21           
  Lines                   ?    1774           
  Branches                ?       0           
==============================================
  Hits                    ?       0           
  Misses                  ?    1774           
  Partials                ?       0           
Flag Coverage Δ
differential 0.00% <0.00%> (?)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@h-ohta
Copy link
Author

h-ohta commented May 26, 2023

ビルド問題ないため、readyです

Copy link

@v-nojiri7841-esol v-nojiri7841-esol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

変更前後でコンソールのビルドログに変化がありませんでした。
修正による変化はどこに生じますか?

変更前 beta/v0.3.16 SHA:7507f0e8d167dbedd3d60c998138ac5d30d25cf0
変更後 SHA:ffe2a39392954e3417e29ea9d3bf431e6b561479

@h-ohta
Copy link
Author

h-ohta commented May 26, 2023

Boostのwarningが出るはずなのですが、出ないでしょうか?

@h-ohta
Copy link
Author

h-ohta commented May 26, 2023

あ、

BOOST_BIND_GLOBAL_PLACEHOLDERS

ってwarningなので、今回の対策だと消えない可能性が高いですね・・・
自分の環境で消えたのは勘違いの可能性が高いです。すみません・・・

@v-nojiri7841-esol
Copy link

Boostのwarningが出るはずなのですが、出ないでしょうか?

出ておりませんでした。

唯一出ているのは以下のBoostのNoteです。変更前後でどちらもでており、Warningではありません。

--- stderr: system_monitor
In file included from /usr/include/boost/bind.hpp:30,
                 from /usr/include/boost/property_tree/json_parser/detail/parser.hpp:7,
                 from /usr/include/boost/property_tree/json_parser/detail/read.hpp:13,
                 from /usr/include/boost/property_tree/json_parser.hpp:16,
                 from /home/se-osaka-dev34/pilot-auto.x1.eva.v4.0.0/src/autoware/universe/system/system_monitor/src/cpu_monitor/cpu_monitor_base.cpp:26:
/usr/include/boost/bind.hpp:36:1: note: ‘#pragma message: The practice of declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated. Please use <boost/bind/bind.hpp> + using namespace boost::placeholders, or define BOOST_BIND_GLOBAL_PLACEHOLDERS to retain the current behavior.’
   36 | BOOST_PRAGMA_MESSAGE(
      | ^~~~~~~~~~~~~~~~~~~~
---

@h-ohta
Copy link
Author

h-ohta commented May 26, 2023

一旦このPRでは意味がないので、クローズします
対応としても一旦無視という形にさせてください
お手数おかけして申し訳ありません

@h-ohta h-ohta closed this May 26, 2023
auto-merge was automatically disabled May 26, 2023 08:56

Pull request was closed

@h-ohta h-ohta deleted the feat/autoware_cmake_system branch May 30, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants