Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update input topic of traffic signal in planning modules #693

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

TomohitoAndo
Copy link

@TomohitoAndo TomohitoAndo commented Jul 28, 2023

Description

Merged this commit to fix the topic name of traffic singal.

The output topic of traffic light recognition was changed here.

related

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x126
Copy link

0x126 commented Jul 31, 2023

@saka1-s 合わせてbagpackerのtopicが変更されてるかチェックお願いします。

@TomohitoAndo TomohitoAndo merged commit d78e6e8 into beta/v0.9.0 Aug 1, 2023
13 checks passed
@TomohitoAndo TomohitoAndo deleted the update-input-topic-traffic-light branch August 1, 2023 05:39
@TomohitoAndo
Copy link
Author

^/perception/(.*)/traffic_signals$|でrosbag取得しているので、bagpackerには影響なし
https://github.com/tier4/autoware_ecu_system_setup/blob/796a5732f81d10ecd9029c3197e57687cf4b18e3/roles/bagpacker/templates/bagpacker_x2.conf.jinja2#L66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants