Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Fix/topic type #158

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Fix/topic type #158

merged 2 commits into from
Dec 16, 2021

Conversation

tkimura4
Copy link
Collaborator

@tkimura4 tkimura4 commented Dec 16, 2021 •
edited
Loading

PR Type

  • Bug Fix

Related Links

Description

  • autoware_planning_msgs/msg/Trajectory -> autoware_auto_planning_msgs/msg/Trajectory
  • autoware_planning_msgs/msg/Approval -> tier4_planning_msgs/msg/Approval

Review Procedure

run planning_simulator

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

1222-takeshi
1222-takeshi approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1222-takeshi 1222-takeshi merged commit 19f1496 into tier4/universe Dec 16, 2021
@1222-takeshi 1222-takeshi deleted the fix/topic_type branch December 16, 2021 07:27
j4tfwm6z pushed a commit that referenced this pull request Feb 1, 2022
@tier4-autoware-private-bot @wep21
@rej55 @taikitanaka3 @tkimura4
sync rc rc/v0.23.0.0 (#165)
c259ba2 
* Add option to select lidar detection model (#450) (#155)

Signed-off-by: wep21 <[email protected]>

* Fix avoidance param (#158)

* disable oclusion spot (#159)

* add imu to state_monitor (#161)

* Add respawn for imu (#164)

Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
Co-authored-by: taikitanaka3 <[email protected]>
Co-authored-by: tkimura4 <[email protected]>
Co-authored-by: wep21 <[email protected]>
j4tfwm6z pushed a commit that referenced this pull request Feb 1, 2022
@tkimura4 @taikitanaka3
Fix/topic type (#158)
4cace96
kazuki527 pushed a commit to kazuki527/autoware_launch that referenced this pull request Apr 25, 2022
@h-ohta
fix: use s1 detection in perception (tier4#158)
65ab307
TakaHoribe pushed a commit that referenced this pull request Jan 20, 2023
@zulfaqar-azmi-t4
fix(lane_change): behavior planning common and lane change param (#158)
53894b3 
* fix(planning): behavior planning common and lane change param

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* revert forward_path_length

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
This was referenced Jan 21, 2023
Merged
Merged
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@1222-takeshi 1222-takeshi 1222-takeshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkimura4 @1222-takeshi