Skip to content

Merge inference track #979

Merged
merged 23 commits into from
Oct 26, 2022
Merged

Merge inference track #979

merged 23 commits into from
Oct 26, 2022

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Oct 10, 2022

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

In this track we added predict method to pipelines. In order to do this we taught some models to make predict with a context and added context into forecast. Hierarchy of base model classes was updated, so we changed examples in some notebooks.

Added

  • Add predict method to pipelines (#954)
  • Implement predict method in SARIMAXModel, AutoARIMAModel, SeasonalMovingAverageModel, DeadlineMovingAverageModel (#948)
  • Make SeasonalMovingAverageModel and DeadlineMovingAverageModel to work with context (#917)
  • Add predict method to models (#935)
  • Implement predict in ensembles (#972)
  • Implement predict in Pipeline, AutoRegressivePipeline (#970)

Changed

  • Changed hierarchy of base models, enable passing context into models (#888)
  • Add RNNModel into test_inference (#966)
  • Make ts required parameter for predict (#981)

Fixed

  • Fix bug with context size in new nns (#951)
  • Fix notebooks get_started, custom_transform_and_model to work with new classes (#974)

Closing issues

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Oct 10, 2022

🚀 Deployed on https://deploy-preview-979--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request October 10, 2022 15:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 12, 2022 16:13 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

Merging #979 (98d317f) into master (326b599) will increase coverage by 0.49%.
The diff coverage is 95.86%.

@@            Coverage Diff             @@
##           master     #979      +/-   ##
==========================================
+ Coverage   85.24%   85.73%   +0.49%     
==========================================
  Files         157      160       +3     
  Lines        8264     8548     +284     
==========================================
+ Hits         7045     7329     +284     
  Misses       1219     1219              
Impacted Files Coverage Δ
etna/models/base.py 86.44% <87.50%> (-1.16%) ⬇️
etna/models/nn/deepar.py 98.93% <87.50%> (-1.07%) ⬇️
etna/models/nn/tft.py 99.10% <87.50%> (-0.90%) ⬇️
etna/ensembles/direct_ensemble.py 94.54% <88.88%> (-1.11%) ⬇️
etna/ensembles/voting_ensemble.py 94.25% <88.88%> (-0.62%) ⬇️
etna/models/mixins.py 95.65% <95.65%> (ø)
etna/pipeline/base.py 94.64% <95.83%> (+0.11%) ⬆️
etna/models/deadline_ma.py 94.44% <96.05%> (+7.14%) ⬆️
etna/ensembles/stacking_ensemble.py 96.46% <96.15%> (-0.48%) ⬇️
etna/pipeline/mixins.py 97.95% <97.95%> (ø)
... and 16 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

# Conflicts:
#	CHANGELOG.md
#	etna/models/tbats.py
#	pyproject.toml
@github-actions github-actions bot temporarily deployed to pull request October 24, 2022 15:56 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 24, 2022 16:37 Inactive
@Mr-Geekman Mr-Geekman marked this pull request as ready for review October 24, 2022 16:49
@review-notebook-app
Copy link

review-notebook-app bot commented Oct 25, 2022

View / edit / reply to this conversation on ReviewNB

alex-hse-repository commented on 2022-10-25T10:44:41Z
----------------------------------------------------------------

Let's try to suppress warnings in this notebook, I see at least two huge warnings here and in the begining of "Custom model" section


@@ -390,7 +390,7 @@
"name": "stderr",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to suppress this warning here too


Reply via ReviewNB

Copy link
Collaborator

@alex-hse-repository alex-hse-repository left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the summary of proposed changes

etna/ensembles/direct_ensemble.py Show resolved Hide resolved
etna/pipeline/mixins.py Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request October 25, 2022 11:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 25, 2022 12:19 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 26, 2022 08:07 Inactive
@alex-hse-repository alex-hse-repository merged commit 43ae404 into master Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants