Implement predict method in SARIMAXModel, AutoARIMAModel, SeasonalMovingAverageModel, DeadlineMovingAverageModel
#948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-948--etna-docs.netlify.app |
Codecov Report
@@ Coverage Diff @@
## inference #948 +/- ##
============================================
Coverage ? 49.70%
============================================
Files ? 132
Lines ? 7586
Branches ? 0
============================================
Hits ? 3771
Misses ? 3815
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alex-hse-repository
suggested changes
Sep 20, 2022
alex-hse-repository
suggested changes
Sep 21, 2022
etna/models/sarimax.py
Outdated
| def _make_prediction( | ||
| self, df: pd.DataFrame, prediction_interval: bool, quantiles: Sequence[float], dynamic: bool | ||
| ) -> pd.DataFrame: | ||
| """Make predictions depending on parameters.""" |
There was a problem hiding this comment.
Emphasize that the main parameter which change the behaviour is dynamic
| sma_model = model() | ||
| def test_sma_model_forecast(simple_df, model): | ||
| _check_forecast(ts=simple_df, model=model(), horizon=7) | ||
| # sma_model = model() |
…make_predictions in SARIMAX
alex-hse-repository
approved these changes
Sep 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Look #928.
Closing issues
Closes #928.