Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResourceTiming] Update TAO-crossorigin-port.sub.html with new style #28936

Merged
merged 1 commit into from
May 18, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 10, 2021

This change rewrites (and renames) the above test to conform to the new
style we're introducing to Resource Timing Web Platform Tests. See
wpt/resource-timing/CodingingConventions.md for what the new style
prescribes.

Bug: 1171767
Change-Id: I84df93ab1165ab1e315dc406144791be3b1a5b28
GithubIssue: w3c/resource-timing#254
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2881945
Reviewed-by: Yoav Weiss <[email protected]>
Commit-Queue: Tom McKee <[email protected]>
Cr-Commit-Position: refs/heads/master@{#883661}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

This change rewrites (and renames) the above test to conform to the new
style we're introducing to Resource Timing Web Platform Tests. See
wpt/resource-timing/CodingingConventions.md for what the new style
prescribes.

Bug: 1171767
Change-Id: I84df93ab1165ab1e315dc406144791be3b1a5b28
GithubIssue: w3c/resource-timing#254
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2881945
Reviewed-by: Yoav Weiss <[email protected]>
Commit-Queue: Tom McKee <[email protected]>
Cr-Commit-Position: refs/heads/master@{#883661}
@tommckee1
Copy link
Contributor

@jpchase

This looks like a similar failure to #28965 ... we're modifying common/get-host-info.sub.js again and, AFAICT, many many tests are running as a result.

What are the next steps here? Admin merge? Try to repro locally?

@jpchase
Copy link

jpchase commented May 18, 2021

Looking at the timeouts in the stability jobs, this does look like another instance of #7660. I will admin merge.

@jpchase jpchase merged commit 0c65de8 into master May 18, 2021
@jpchase jpchase deleted the chromium-export-cl-2881945 branch May 18, 2021 14:02
@tommckee1
Copy link
Contributor

Awesome! Thanks for the help Jason!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants