Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for loading files, decoding them as JSONL, and formatting them using a Logback-like format string. #46

Merged
merged 90 commits into from
Jul 3, 2024
Merged

Add support for loading files, decoding them as JSONL, and formatting them using a Logback-like format string. #46

merged 90 commits into from
Jul 3, 2024

Conversation

junhaoliao
Copy link
Collaborator

@junhaoliao junhaoliao commented Jun 14, 2024 •
edited
Loading

References

#45

Description

  1. Implement LogFileManager class for efficient log file handling.
  2. Add decoder interface.
  3. Add Decode Options to File Loading Process.
  4. Add support for JSONL log file decoding.

Validation performed

  1. Placed example.jsonl file under /public/test. (Can be downloaded and extracted from example.jsonl.zip)
  2. Launched debug server with npm run start.
  3. Observed last page of decoded results displayed in the browser. e.g.:
    image

@junhaoliao
Copy link
Collaborator Author

@Henry8192 Please help triage the review.

@junhaoliao junhaoliao changed the title WIP - Add log file management and jsonl decoder functionality. Add log file management and jsonl decoder functionality. Jun 14, 2024
Henry8192
Henry8192 reviewed Jun 15, 2024
View reviewed changes
Copy link
Collaborator

@Henry8192 Henry8192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some JSDocs.

new-log-viewer/src/components/Layout.tsx Outdated Show resolved Hide resolved
new-log-viewer/src/services/decoders/JsonlDecoder.ts Outdated Show resolved Hide resolved
new-log-viewer/src/services/decoders/JsonlDecoder.ts Outdated Show resolved Hide resolved
new-log-viewer/src/services/decoders/JsonlDecoder.ts Outdated Show resolved Hide resolved
new-log-viewer/src/services/decoders/JsonlDecoder.ts Outdated Show resolved Hide resolved
new-log-viewer/src/services/decoders/JsonlDecoder.ts Outdated Show resolved Hide resolved
new-log-viewer/src/services/LogFileManager.ts Outdated Show resolved Hide resolved
new-log-viewer/src/services/LogFileManager.ts Show resolved Hide resolved
kirkrodrigues
kirkrodrigues requested changes Jun 16, 2024
View reviewed changes
new-log-viewer/src/contexts/StateContextProvider.tsx Show resolved Hide resolved
new-log-viewer/src/contexts/StateContextProvider.tsx Outdated Show resolved Hide resolved
new-log-viewer/src/components/Layout.tsx Outdated Show resolved Hide resolved
new-log-viewer/src/contexts/StateContextProvider.tsx Outdated Show resolved Hide resolved
new-log-viewer/src/services/MainWorker.ts Show resolved Hide resolved
new-log-viewer/src/services/LogFileManager.ts Outdated Show resolved Hide resolved
new-log-viewer/src/services/LogFileManager.ts Outdated Show resolved Hide resolved
new-log-viewer/src/services/LogFileManager.ts Outdated Show resolved Hide resolved
new-log-viewer/src/services/LogFileManager.ts Outdated Show resolved Hide resolved
new-log-viewer/src/services/LogFileManager.ts Outdated

messages.push(m);
lines.set(currentLine, logEventNum);
currentLine += m.split("\n").length - 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something to think about for the future---perhaps we should return the number of lines per log event from the decoder.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. how do we plan to use that? With that approach, we would have to use an accumulator to deduct the log event Num (index) from the editor cursor line, right? (Do you mean we send the lines per log event to the renderer, and let the renderer calculate once and cache the beginLineNumToLogEventNum[]?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just mean we could use it here instead of calling msg.split('\n').length - 1 every time we load a page.

junhaoliao and others added 14 commits June 18, 2024 01:23
@junhaoliao @Henry8192
Apply suggestions from code review
551bf81 
Co-authored-by: Henry8192 <[email protected]>
@junhaoliao @Henry8192
Apply suggestions from code review
1cedfbf 
Co-authored-by: Henry8192 <[email protected]>
@junhaoliao
Update last log event number logic in StateContextProvider.
7339ad5
@junhaoliao
Add error handling.
50690be
@junhaoliao
Refactor decoder object in src/services and src/typings.
fff469d
@junhaoliao
Refactor loadPage docs and variable names in LogFileManager.
96e26e9
@junhaoliao
Typify cursor handling.
66c3293
@junhaoliao
Rename global constant name from 'StateDefaultValue' to 'STATE_DEFAULT'.
384836f
@junhaoliao @kirkrodrigues
Apply suggestions from code review
a7d8f0e 
Co-authored-by: kirkrodrigues <[email protected]>
@junhaoliao @Henry8192
Apply suggestions from code review
b316f0c 
Co-authored-by: Henry8192 <[email protected]>
@junhaoliao @Henry8192
Apply suggestions from code review
a7f7660 
Co-authored-by: Henry8192 <[email protected]>
@junhaoliao @Henry8192
Apply suggestions from code review
582f0de 
Co-authored-by: Henry8192 <[email protected]>
@junhaoliao @Henry8192
Apply suggestions from code review
be100d8 
Co-authored-by: Henry8192 <[email protected]>
@junhaoliao @kirkrodrigues
Apply suggestions from code review
1545e05 
Co-authored-by: kirkrodrigues <[email protected]>
@Henry8192 Henry8192 mentioned this pull request Aug 23, 2024
Merged
This was referenced Aug 28, 2024
Merged
Merged
Open
Closed
This was referenced Sep 11, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@davemarco davemarco mentioned this pull request Sep 25, 2024
Merged
This was referenced Sep 26, 2024
Merged
Merged
This was referenced Sep 27, 2024
Merged
Merged
This was referenced Sep 30, 2024
Merged
Merged
Merged
@davemarco davemarco mentioned this pull request Oct 4, 2024
Merged
@Henry8192 Henry8192 mentioned this pull request Oct 7, 2024
Merged
This was referenced Oct 14, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Oct 22, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirkrodrigues kirkrodrigues kirkrodrigues approved these changes

@Henry8192 Henry8192 Awaiting requested review from Henry8192

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@junhaoliao @kirkrodrigues @Henry8192