Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new-log-viewer: Fix lint errors introduced in #59. #70

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

junhaoliao
Copy link
Collaborator

@junhaoliao junhaoliao commented Sep 12, 2024

References

new-log-viewer series: #45 #46 #48 #51 #52 #53 #54 #55 #56 #59 #60 #61 #62 #63 #66 #67 #68 #69

Description

  1. Update JSDoc comments in config utilities to include throwables for unhandled config items.
  2. Fix max line length violation.

Validation performed

  1. Ran npm run lint and observed no lint violation.

kirkrodrigues
kirkrodrigues previously approved these changes Sep 12, 2024
Copy link
Member

@kirkrodrigues kirkrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit but otherwise lgtm.

new-log-viewer/src/utils/config.ts Outdated Show resolved Hide resolved
@junhaoliao junhaoliao merged commit 2f653eb into y-scope:main Sep 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants