Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-actions: Add lint workflow for new-log-viewer. #61

Merged
merged 15 commits into from
Sep 2, 2024
Merged

gh-actions: Add lint workflow for new-log-viewer. #61

merged 15 commits into from
Sep 2, 2024

Conversation

junhaoliao
Copy link
Collaborator

@junhaoliao junhaoliao commented Aug 28, 2024 •
edited
Loading

References

new-log-viewer series: #45 #46 #48 #51 #52 #53 #54 #55 #56 #59

Description

  1. gh-actions: Add lint workflow for new-log-viewer.
  2. Fix / Suppress all existing lint errors.

Validation performed

  1. Created a junhaoliao:gh-action-test branch from junhaoliao:main.
  2. Made modification in various files in multiple commits.
  3. After the GitHub Check was finished, observed all violations got marked by annotations: https://github.com/junhaoliao/yscope-log-viewer/pull/5/files .

@junhaoliao junhaoliao mentioned this pull request Aug 28, 2024
Closed
This was referenced Sep 1, 2024
Merged
Merged
kirkrodrigues
kirkrodrigues reviewed Sep 1, 2024
View reviewed changes
.github/workflows/lint.yaml Show resolved Hide resolved
.github/workflows/lint.yaml Outdated Show resolved Hide resolved
.github/workflows/lint.yaml Show resolved Hide resolved
junhaoliao
junhaoliao commented Sep 2, 2024
View reviewed changes
.github/workflows/lint.yaml Outdated Show resolved Hide resolved
new-log-viewer/package.json Outdated Show resolved Hide resolved
@junhaoliao
Copy link
Collaborator Author

Latest action run at https://github.com/junhaoliao/yscope-log-viewer/pull/5/files shows the annotations correctly.
Snapshot: gh-action-test by junhaoliao · Pull Request #5 · junhaoliao_yscope-log-viewer.pdf

@junhaoliao junhaoliao requested review from kirkrodrigues and removed request for kirkrodrigues September 2, 2024 16:33
@kirkrodrigues
Copy link
Member

Looks good. Can you resolve the conflict?

@junhaoliao
Merge branch 'main' into gh-action
53e5675 
# Conflicts:
#	new-log-viewer/src/services/LogFileManager.ts
@junhaoliao
Copy link
Collaborator Author

Looks good. Can you resolve the conflict?

just merged. done

@junhaoliao junhaoliao merged commit 867b72e into y-scope:main Sep 2, 2024
@junhaoliao junhaoliao mentioned this pull request Sep 2, 2024
Closed
This was referenced Sep 11, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@davemarco davemarco mentioned this pull request Sep 25, 2024
Merged
This was referenced Sep 26, 2024
Merged
Merged
This was referenced Sep 27, 2024
Merged
Merged
This was referenced Sep 30, 2024
Merged
Merged
Merged
@davemarco davemarco mentioned this pull request Oct 4, 2024
Merged
@Henry8192 Henry8192 mentioned this pull request Oct 7, 2024
Merged
This was referenced Oct 14, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Oct 22, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirkrodrigues kirkrodrigues kirkrodrigues approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junhaoliao @kirkrodrigues