-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BBC /reel/video/ #21870
Comments
Fixed in #23415 |
I confirm. Just tried the |
This seems broken again, in 2021.01.03. It fails at https://www.bbc.com/reel/video/p0931jtk/the-nuclear-lighthouses-built-by-the-soviets-in-the-arctic
|
There have been recent c32a059 , and #23415 was never merged... However, the workaround I posted here, 11 months ago, still works for your referenced reel clip:
|
Thank you! That's very helpful. |
This fragment of PR #23415 can be added to the current (well, 2021-02-04.1) master and the listed BBC Reel clip can then be downloaded:
|
* https://github.com/ytdl-org/youtube-dl: [9c9media] fix extraction for videos with multiple ContentPackages(closes ytdl-org#28309) [bbc] correct catched exception type [bbc] add support for BBC Reel videos(closes ytdl-org#21870, closes ytdl-org#23660, closes ytdl-org#28268) release 2021.03.02 [ChangeLog] Actualize [ci skip] [zdf] Rework extractors (closes ytdl-org#11606, closes ytdl-org#13473, closes ytdl-org#17354, closes ytdl-org#21185, closes ytdl-org#26711, closes ytdl-org#27068, closes ytdl-org#27930, closes ytdl-org#28198, closes ytdl-org#28199, closes ytdl-org#28274)
While indeed e465b25 brought native support for BBC Reel videos to bbcIE, the tip/hack/workaround I posted previously in this thread is still valid in some cases if you're looking for a 720p50 HD encode, because current implementation maxes out at 540p25 SD encodes... I just compiled locally from the master branch (snapshot 2021.03.02+3-git-20210302-g8f56907) and here are the results of
whereas
Both tests from an overseas location... Just as a FYI... |
Not fetching the highest resolution formats has been reported for other bbc.com URIs. I assume it's because the The recent PR extracts everything from the Reel page, as only a subset of the available metadata is provided through the There is a technique that gets the best of both worlds. The programme's metadata can be populated from the Reel page (only a subset of this metadata is available through the |
As I'm not a Python coder myself, I won't pollute the conversation in #28332; but, here are some things to consider: Not ALL reel clips return 720p50 encodes when the equivalent
i.e. maxes at 540p25, while
... i.e., as said above, maxes at 396p50 👎 My proposal is to use both mediasets, so that we can at least guarantee the 540p25 encodes in the absence of BBC HD (540p50+720p50) ... |
well, it appears that this would require more testing, the |
I highly appreciate your reply @remitamine 😃 Here's the rundown on things: Case A: BBC provide HD (540p50+720p50) encodes for a given vPID;
http://open.live.bbc.co.uk/mediaselector/6/select/version/2.0/mediaset/pc/vpid/p0931jtm/format/xml (MPEG-DASH+HLS streams) while the iptv-all mediaset will retrieve 720p50, 540p50, 396p50 & 396p25 streams: http://open.live.bbc.co.uk/mediaselector/6/select/version/2.0/mediaset/iptv-all/vpid/p0931jtm/format/xml (MPEG-DASH+HLS streams) Querying both mediasets, removing duplication and combining results, one gets the full list of:
Case B: BBC do not provide HD (540p50+720p50) encodes for a given vPID;
http://open.live.bbc.co.uk/mediaselector/6/select/version/2.0/mediaset/pc/vpid/p07c6sb9/format/xml (MPEG-DASH+HLS streams) while the iptv-all mediaset will only retrieve 396p50 & 396p25 streams: http://open.live.bbc.co.uk/mediaselector/6/select/version/2.0/mediaset/iptv-all/vpid/p07c6sb9/format/xml (MPEG-DASH+HLS streams) Again, querying both mediasets, removing duplication and combining results, one gets the full list of:
Is there a programmatic reason we don't want |
Checklist
Verbose log
Description
ERROR: no suitable InfoExtractor for URL https://www.bbc.co.uk/programmes/None
Video url is https://www.bbc.com/reel/video/p07f3mvf/stonewall-riots-i-wanted-to-kill-the-police-
The text was updated successfully, but these errors were encountered: