Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main #16130

Merged
merged 48 commits into from
Jul 2, 2021
Merged

Merge main #16130

merged 48 commits into from
Jul 2, 2021

Commits on Jun 25, 2021

  1. [event-hubs] migrate samples to v2 (Azure#15053)

    Followed the steps at https://github.com/Azure/azure-sdk-for-js/wiki/Samples-v2-Migration-Guide
    /cc @willmtemple 
    
    Note: I moved browserSamples and expressSamples into the generated v5 samples folder since dev-tool doesn't work with those.
    chradek authored Jun 25, 2021
    Configuration menu
    Copy the full SHA
    2f90a87 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9440254 View commit details
    Browse the repository at this point in the history
  3. [ContainerRegistry] Update delete image sample (Azure#16002)

    to delete tags before delete the image as this is the recommended best
    practice for the service.
    jeremymeng authored Jun 25, 2021
    Configuration menu
    Copy the full SHA
    ca61eb9 View commit details
    Browse the repository at this point in the history
  4. [Identity] Test improvements (Azure#15999)

    * [Identity] Test improvements
    
    * temporary node 16 fix
    
    * Since unhandled promise rejections are not supported in Node 16, tickAsync can't be awaited
    
    * fix the test
    
    Co-authored-by: Harsha Nalluru <[email protected]>
    sadasant and HarshaNalluru authored Jun 25, 2021
    Configuration menu
    Copy the full SHA
    4ccc8d9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    63b6236 View commit details
    Browse the repository at this point in the history
  6. [KeyVault] - Add support for getRandomBytes operation (Azure#15955)

    ## What
    
    - Regenerate from 7.3-preview swagger
    - Add `getRandomBytes` method
    
    ## Why
    
    - For July we would like to add support for the RNG endpoint in a Managed HSM. While this is a customer ask for Java, we will add this to all languages at the same time.
    maorleger authored Jun 25, 2021
    Configuration menu
    Copy the full SHA
    f3a8efe View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4784937 View commit details
    Browse the repository at this point in the history
  8. Prepare to move to @types/node v12 (Azure#16012)

    As part of AzureSDKAutomation#7022, we will be moving the version of `@types/node` from 8 to 12
    This PR has the changes required to fix the build errors that occurred when trying out this change
    - The [Agent](https://nodejs.org/docs/latest-v12.x/api/http.html#http_class_http_agent) class in Node.js 12 has an extra property `maxTotalSockets`. The docs say there is a default value for this, but it it is still marked as a mandatory property in the types. We use our own interface for this class for the purposes of user providing their own custom agent. Am casting it in this PR to the expected type. If anyone has better ideas here, am all ears :)
    - `global.URL` is not a thing as per the types for Node.js 12. We needed this to support Node.js 8
    - Fixing the types for `port` in the parsed url
    
    The actual move to v12 for `@types/node` will be done in a separate PR
    ramya-rao-a authored Jun 25, 2021
    Configuration menu
    Copy the full SHA
    82085ff View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b729674 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2021

  1. Configuration menu
    Copy the full SHA
    1a5d100 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b8da289 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. Prepare Storage packages to move to @types/node v12 (Azure#16020)

    * Use BufferEncoding as encoding is not a string in Node.js 12
    
    * Fix typing issue for fsStat returning unknown
    ramya-rao-a authored Jun 28, 2021
    Configuration menu
    Copy the full SHA
    ff90eba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    23de687 View commit details
    Browse the repository at this point in the history
  3. [Cosmos] Simple endpoint refresh interval (Azure#15781)

    * adds simple background refresh
    
    * Adds setInterval with unref
    
    * cleanup
    
    * wip prenock
    
    * wip
    
    * Removes recorder, fixes timeout in tests
    
    * extract api
    
    * fix lint
    
    * format
    
    * Adds flag
    
    * lint
    
    * Fix parition spelling
    
    * modify endpoint check
    
    * fix tests
    
    * Comment proxy
    
    * adds back copyright
    
    * skip session spec
    
    * Fix session token
    
    * Fix session spec on emulator
    zfoster authored Jun 28, 2021
    Configuration menu
    Copy the full SHA
    d3647f8 View commit details
    Browse the repository at this point in the history
  4. Support track2 management packages (Azure#15975)

    * Support track2 management packages
    praveenkuttappan authored Jun 28, 2021
    Configuration menu
    Copy the full SHA
    00ea067 View commit details
    Browse the repository at this point in the history
  5. Fix lint script for app config perf test (Azure#16046)

    Perf test packages should not be using the eslint plugin
    
    Fixes the below error
    
    ```
    
    
    ESLint couldn't find the plugin "@azure/eslint-plugin-azure-sdk".
    
    (The package "@azure/eslint-plugin-azure-sdk" was not found when loaded as a Node module from the directory "/home/vsts/work/1/s/sdk".)
    
    It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
    
        npm install @azure/eslint-plugin-azure-sdk@latest --save-dev
    
    The plugin "@azure/eslint-plugin-azure-sdk" was referenced from the config file in "../../../.eslintrc.json".
    
    ```
    ramya-rao-a authored Jun 28, 2021
    Configuration menu
    Copy the full SHA
    facf5c1 View commit details
    Browse the repository at this point in the history
  6. [core-rest] - Update core-client-paging-rest to use the latest core-r…

    …est-pipeline (Azure#16045)
    
    This PR updates the newly added `@azure-rest/core-client-paging` package to use the same version of `@azure/core-rest-pipeline` that the other packages use.
    
    We recently GA'd (on main, not released yet) version 1.1.0 of `@azure/core-rest-pipeline` and want to keep everyone on the latest version.
    maorleger authored Jun 28, 2021
    Configuration menu
    Copy the full SHA
    37d3ed9 View commit details
    Browse the repository at this point in the history
  7. Fix linter errors in app config perf tests (Azure#16048)

    Follow up for Azure#16046 to fix the resulting linter errors
    ramya-rao-a authored Jun 28, 2021
    Configuration menu
    Copy the full SHA
    13772c2 View commit details
    Browse the repository at this point in the history
  8. [web-pubsub] Migrate @azure/web-pubsub to new core pipeline (Azure#…

    …16010)
    
    Update to latest core packages and improve pipeline robustness.
    xirzec authored Jun 28, 2021
    Configuration menu
    Copy the full SHA
    21f28dc View commit details
    Browse the repository at this point in the history
  9. [EventGrid] Move to Core V2 Generator (Azure#16047)

    As part of the development of the new pipeline, event grid was hand
    ported to use the new pipeline. Now that the code generator targets
    the new pipeline, we can start using it to generate the code.
    
    Since EventGrid includes the `/api/events` path segment in the
    Endpoint, We need to do a small amount of post processing of the
    generated code, to ensure `/api/events` is not appended to the
    endpoint (we do this by setting an empty path in the operation spec,
    which is as things were before moving over to the generator).
    
    Fixes Azure#15823
    ellismg authored Jun 28, 2021
    Configuration menu
    Copy the full SHA
    5c5c2cf View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    018fd46 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    8919e6a View commit details
    Browse the repository at this point in the history
  12. [Identity] Add support for Bridge to Kubernetes to ManagedIdentityCre…

    …dential (Azure#15856)
    
    * [Identity] Add support for Bridge to Kubernetes to ManagedIdentityCredential
    
    * one very simple test
    
    * forgot this line
    sadasant authored Jun 28, 2021
    Configuration menu
    Copy the full SHA
    ec4abba View commit details
    Browse the repository at this point in the history
  13. [Azure Monitor Exporter] Separate tests into internal and public fold…

    …ers (Azure#15932)
    
    * [Monitor Exporter] Separate tests into internal and public folders
    
    * fix build
    
    * put tests in internal
    
    * prettier
    
    * console log for testing
    
    * testing
    
    * format
    
    * console
    
    * try flush processor
    
    * format
    
    * remove console logs
    xiao-lix authored Jun 28, 2021
    Configuration menu
    Copy the full SHA
    df68c3e View commit details
    Browse the repository at this point in the history
  14. [synapse] - Ignore known rollup warnings (Azure#15948)

    ## What
    
    - Adds warning filter to ignore known rollup warnings that are safe to ignore
    - Ignore `this has been rewritten to undefined` in synapse
    - Ignore circular dependencies in synapse
    
    ## Why
    
    These are both known warnings, are safe to ignore, and add noise to the build output unnecessarily. 
    
    The first is totally safe to ignore:
    
    ```
    var __spreadArray = (this && this.__spreadArray) || function (to, from) {
    ```
    
    Is emitted from TypeScript in the OTel ESM and is safe to use.
    The second is a known issue in OTel 1.0.0 that is not harmful at runtime.
    
    Finally, we have precedent for doing the exact same thing in other packages like service-bus.
    maorleger authored Jun 28, 2021
    Configuration menu
    Copy the full SHA
    5b4eac3 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    5a7c129 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2021

  1. Update contributing guide to reflect Node.js support (Azure#16057)

    The watchful eyes of @vishnureddy17 found that we still have reference to Node.js 8 in our Contributing Guide!!
    
    This PR fixes that.
    
    Related to AzureSDKAutomation#7022
    ramya-rao-a authored Jun 29, 2021
    Configuration menu
    Copy the full SHA
    f854a85 View commit details
    Browse the repository at this point in the history
  2. Update identity to 2.0.0-beta.4 for quantum jobs (Azure#15801)

    * Update identity to 2.0.0-beta.4 for quantum jobs
    
    * Fix CI Errors
    
    * Fix CI Errors
    sarangan12 authored Jun 29, 2021
    Configuration menu
    Copy the full SHA
    9699830 View commit details
    Browse the repository at this point in the history
  3. [core] Retry on 503 using the Retry-After header (Azure#15906)

    Based on the Retry-After specification, 503 should also be supported when considering the Retry-After header.
    
    This also aligns with upcoming Identity plans.
    sadasant authored Jun 29, 2021
    Configuration menu
    Copy the full SHA
    c8126be View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b17fb63 View commit details
    Browse the repository at this point in the history
  5. [Identity] [InteractiveBrowserCredential] [Node] Enable PKCE (Azure#1…

    …5853)
    
    This PR enables PKCE on the InteractiveBrowserCredential.
    
    We don’t have tests for this yet. I’ll make sure to test it manually, at least.
    
    Fixes Azure#15168
    sadasant authored Jun 29, 2021
    Configuration menu
    Copy the full SHA
    36b468c View commit details
    Browse the repository at this point in the history
  6. [monitor-query] Regenerate client with stable swaggers and add in inc…

    …ludeVisualization option. (Azure#16058)
    
    * Big update to use the latest stable swagger files for all of the Log Analytics services. Each reference is by git commit ID this time to prevent any accidental drift.
    
    Also, added in the includeRender header (via the `includeVisualization` option).
    
    Fixes Azure#15771
    
    * Fixing codeowners to reflect the proper owners for the package:
    @KarishmaGhiya - main owner
    @maorleger - backup owner
    
    * Formatting!
    richardpark-msft authored Jun 29, 2021
    Configuration menu
    Copy the full SHA
    d4d5002 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8236d61 View commit details
    Browse the repository at this point in the history
  8. Convenience Method to create a synonymmap object (Azure#16054)

    * Convenience Method to create a synonymmap object
    
    * Update sdk/search/search-documents/src/synonymMapHelper.ts
    
    Co-authored-by: Jeff Fisher <[email protected]>
    
    * Fix for PR Comments
    
    Co-authored-by: Jeff Fisher <[email protected]>
    sarangan12 and xirzec authored Jun 29, 2021
    Configuration menu
    Copy the full SHA
    20321ef View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2021

  1. [Identity] InteractiveBrowserCredential loginHint (Azure#15855)

    * [Identity] InteractiveBrowserCredential LoginHint
    
    * formatting
    
    * Update CHANGELOG.md
    sadasant authored Jun 30, 2021
    Configuration menu
    Copy the full SHA
    14fddf7 View commit details
    Browse the repository at this point in the history
  2. Sync eng/common directory with azure-sdk-tools for PR 1725 (Azure#16079)

    * Bring changes from JS docs metadata
    
    * Move business logic inside Update-DocsMsMetadata.ps1
    
    * Update with the latest changes in JS PR
    
    * Update from latest PR feedback
    
    * Add check for empty path to prevent crashes when creating relative paths
    
    Co-authored-by: Daniel Jurek <[email protected]>
    azure-sdk and danieljurek authored Jun 30, 2021
    Configuration menu
    Copy the full SHA
    528f940 View commit details
    Browse the repository at this point in the history
  3. [core] - Update release dates for July Release (Azure#16069)

    This PR just updates the release dates for core releases that I plan to release:
    
    - @azure/core-tracing
    - @azure/core-http
    - @azure/core-rest-pipeline
    - @azure/core-client
    - @azure/core-lro
    - @azure/core-auth
    maorleger authored Jun 30, 2021
    Configuration menu
    Copy the full SHA
    702007a View commit details
    Browse the repository at this point in the history
  4. Update devops workitem helpers (Azure#16083)

    - Switch to using rest instead of cli for querying work items
      as cli is limited to 1000 items only.
    - Fix issues with Generated fields not being set.
    - Correctly sort older workitems by version isntead of string.
    
    Co-authored-by: Wes Haggard <[email protected]>
    azure-sdk and weshaggard authored Jun 30, 2021
    Configuration menu
    Copy the full SHA
    bbd295a View commit details
    Browse the repository at this point in the history
  5. [event-hubs] add AmqpAnnotatedMessage support (Azure#15939)

    * [event-hubs] add AmqpAnnotatedMessage support
    
    * undo experimental deletion of decode method from service bus
    
    * address feedback
    chradek authored Jun 30, 2021
    Configuration menu
    Copy the full SHA
    19d0e76 View commit details
    Browse the repository at this point in the history
  6. update core-client version to 1.2.1 (Azure#16109)

    See Azure#16094 for details. This PR just updates core-client to 1.2.1 so I can release it
    maorleger authored Jun 30, 2021
    Configuration menu
    Copy the full SHA
    39d2a80 View commit details
    Browse the repository at this point in the history
  7. fix core-http changelog (Azure#16116)

    The release pipeline complains if there are empty sections in the changelog. Removing the empty section to correct this and unblock core-http release.
    maorleger authored Jun 30, 2021
    Configuration menu
    Copy the full SHA
    44ba530 View commit details
    Browse the repository at this point in the history
  8. Sync eng/common directory with azure-sdk-tools for PR 1763 (Azure#16091)

    * Disable release date check
    
    * Release check is not finding release date
    
    Co-authored-by: Praveen Kuttappan <[email protected]>
    azure-sdk and praveenkuttappan authored Jun 30, 2021
    Configuration menu
    Copy the full SHA
    f143bcf View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    40dd9e4 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    761a4e6 View commit details
    Browse the repository at this point in the history
  11. [Identity] Support for tenant Id Challenges / tenant discovery in Cli…

    …entCredentials (Azure#15837)
    
    This PR adds `tenantId` to the `getTokenOptions`, and adds options on every Identity credential to allow multi-tenant authentication (which will be disabled by default).
    
    Fixes Azure#15797
    sadasant authored Jun 30, 2021
    Configuration menu
    Copy the full SHA
    d8407ad View commit details
    Browse the repository at this point in the history
  12. Increment version for core releases (Azure#16113)

    * Increment package version after release of azure-core-tracing
    
    * Increment package version after release of azure-core-lro
    
    * Increment package version after release of azure-core-rest-pipeline
    
    * Run rush update
    
    Co-authored-by: Maor Leger <[email protected]>
    azure-sdk and maorleger authored Jun 30, 2021
    Configuration menu
    Copy the full SHA
    020a075 View commit details
    Browse the repository at this point in the history
  13. Increment version for core releases (Azure#16125)

    * Increment package version after release of azure-core-http
    
    * Increment package version after release of azure-core-client
    azure-sdk authored Jun 30, 2021
    Configuration menu
    Copy the full SHA
    cec69b6 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2021

  1. [service-bus] Fix message loss issues with peekLock and receiveAndDel…

    …ete (Azure#15989)
    
    Fixing an issue where we could lose messages or provoke an alarming message from rhea (`Received transfer when credit was 0`)
        
    The message loss issue is related to how we trigger 'drain' using 'addCredit(1)'. Our 'receiver.drain; receiver.addCredit(1)' pattern actually does add a credit, which shows up in the flow frame that gets sent for our drain. This has led to occasionally receiving more messages than we intended.
        
    The second part of this was that we were masking this error because we had code that specifically threw out messages if more arrived than were requested. If the message was being auto-renewed it's possible for the message to appear to be missing, and if we were in receiveAndDelete the message is effectively lost at that point. That code is now removed (we defer to just allowing the extrra message, should a bug arise that causes that) and we log an error indicating it did happen.
        
    The rhea error message appeared to be triggered by our accidentally allowing multiple overlapping 'drain's to occur (finalAction did not check to see if we were _already_ draining and would allow it to happen multiple times). Removing the concurrent drains fixed this issue but I didn't fully investigate why.
    
    Fixes Azure#15606, Azure#15115
    richardpark-msft authored Jul 1, 2021
    Configuration menu
    Copy the full SHA
    d75f119 View commit details
    Browse the repository at this point in the history