Fix G2/G3 so that slicer rounding error don't result in impossible arcs #15544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: marcio-ao <[email protected]>
Homing on the Ender 3 with `HOMING_FEEDRATE_XY` set to 50*60 was shown (#12074) to cause the end-stop micro-switches to bottom out, causing the carriage for both X and Y axis to physically crash into the micro switch. Reducing the homing speed prevents the switches from bottoming out.
Remove obsolete workarounds in G33 for the now fixed zprobe_zoffset bug
V3 of the BLTouch has an [Alarm Release & Touch mode](https://docs.wixstatic.com/ugd/f5a1c8_77037f55e5d542309d9fc178165c9f3f.pdf) to activate after the probe is deployed. If this mode isn't activated, the BLTouch keeps deploying, ends up detecting a collision and gets itself in error mode. Tested on a Creality Ender-3.
Counterpart to #13595 Co-Authored-By: swilkens <[email protected]>
Co-Authored-By: InsanityAutomation <[email protected]>
see PR #14857 for details
This reverts commit 73f4027.
Co-Authored-By: thisiskeithb <[email protected]>
|
Something went wrong here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description
Back-porting the bugfix-2.0.x G2/G3 fix to bugfix-1.1.x
This handles the possibility that slicer rounding error results in a geometrically impossible arc with a diameter less than the distance to the destination point.
Benefits
Fixes #14745
Related Issues