-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(config.py): fix config assertion #174
Conversation
Co-authored-by: borong <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ruiyang sun <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: ruiyang sun <[email protected]>
Co-authored-by: zmsn-2077 <[email protected]> Co-authored-by: borong <[email protected]> Co-authored-by: friedmainfunction <[email protected]>
…nment#147) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…thms (PKU-Alignment#148) Co-authored-by: borong <[email protected]> Co-authored-by: Gaiejj <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: zmsn-2077 <[email protected]>
Co-authored-by: borong <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: ruiyang sun <[email protected]> Co-authored-by: zmsn-2077 <[email protected]> Co-authored-by: friedmainfunction <[email protected]> Co-authored-by: Gaiejj <[email protected]> Co-authored-by: zmsn-2077 <[email protected]> Co-authored-by: Ruiyang Sun <[email protected]> Co-authored-by: Jiayi Zhou <[email protected]> Co-authored-by: 1Asan <[email protected]> fix(algo): fix no return in algo_wrapper::learn (PKU-Alignment#122) fix(logger, wrapper): support csv file and velocity tasks (PKU-Alignment#131) fix typo. (PKU-Alignment#134) fix(ppo): fix entropy loss (PKU-Alignment#135) fix bugs (PKU-Alignment#136) fix: support new config for exp_grid (PKU-Alignment#142) fix(rollout, exp_grid): fix logdir path conflict (PKU-Alignment#145) fix(on-policy): fix the second order algorithms performance (PKU-Alignment#147)
…lignment#162) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: borong <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #174 +/- ##
=======================================
Coverage 86.42% 86.42%
=======================================
Files 80 80
Lines 3757 3757
=======================================
Hits 3247 3247
Misses 510 510
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description
Something wrong in the assertion of
config.py
.We wanted to check if
standardized_cost_adv
andstandardized_rew_adv
are of typebool
. But because of a typo, we wroteTrue
. This PR fix this bug.Motivation and Context
It solve issue #173
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format
. (required)make lint
. (required)make test
pass. (required)