-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔖 Runtime Upgrade #383
Merged
Merged
🔖 Runtime Upgrade #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @JuaniRios and the rest of your teammates on Graphite |
JuaniRios
force-pushed
the
08-27-runtime_upgrade
branch
3 times, most recently
from
August 30, 2024 10:50
10ad3c5
to
94677aa
Compare
Merged
JuaniRios
force-pushed
the
08-29-runtime-benchmarks
branch
from
August 30, 2024 11:01
561d240
to
c82439a
Compare
JuaniRios
force-pushed
the
08-27-runtime_upgrade
branch
from
August 30, 2024 11:01
94677aa
to
ff762a6
Compare
JuaniRios
force-pushed
the
08-29-runtime-benchmarks
branch
from
August 30, 2024 11:32
c82439a
to
9777af1
Compare
JuaniRios
force-pushed
the
08-27-runtime_upgrade
branch
from
August 30, 2024 11:32
ff762a6
to
4a328d7
Compare
This was referenced Aug 30, 2024
Merged
JuaniRios
force-pushed
the
08-29-runtime-benchmarks
branch
from
August 30, 2024 14:29
9777af1
to
0a26d75
Compare
JuaniRios
force-pushed
the
08-27-runtime_upgrade
branch
from
August 30, 2024 14:29
4a328d7
to
2a701d7
Compare
Merged
lrazovic
force-pushed
the
08-29-runtime-benchmarks
branch
from
August 30, 2024 15:43
0a26d75
to
3b8db19
Compare
JuaniRios
force-pushed
the
08-29-runtime-benchmarks
branch
from
September 2, 2024 08:33
3b8db19
to
83b8afc
Compare
JuaniRios
force-pushed
the
08-27-runtime_upgrade
branch
from
September 2, 2024 08:33
2a701d7
to
ada9f02
Compare
JuaniRios
force-pushed
the
08-29-runtime-benchmarks
branch
from
September 2, 2024 09:34
83b8afc
to
6bac2f6
Compare
JuaniRios
force-pushed
the
08-27-runtime_upgrade
branch
from
September 2, 2024 09:34
ada9f02
to
69bc130
Compare
Graphite Automations"Auto-assign PRs to author" took an action on this PR • (09/02/24)1 assignee was added to this PR based on Juan Ignacio Rios's automation. |
JuaniRios
force-pushed
the
08-27-runtime_upgrade
branch
from
September 2, 2024 15:22
69bc130
to
a909ca1
Compare
Closed
This was referenced Sep 3, 2024
Merged
lrazovic
requested changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JuaniRios
force-pushed
the
08-27-runtime_upgrade
branch
from
September 3, 2024 13:20
a909ca1
to
7345191
Compare
lrazovic
requested changes
Sep 3, 2024
JuaniRios
force-pushed
the
08-27-runtime_upgrade
branch
from
September 3, 2024 14:06
7345191
to
df72942
Compare
lrazovic
approved these changes
Sep 3, 2024
Merge activity
|
JuaniRios
force-pushed
the
08-29-runtime-benchmarks
branch
2 times, most recently
from
September 3, 2024 14:16
4b6181a
to
00711f2
Compare
JuaniRios
force-pushed
the
08-27-runtime_upgrade
branch
from
September 3, 2024 14:16
df72942
to
348dc72
Compare
JuaniRios
changed the base branch from
08-29-runtime-benchmarks
to
graphite-base/383
September 3, 2024 14:25
JuaniRios
force-pushed
the
08-27-runtime_upgrade
branch
from
September 3, 2024 14:25
348dc72
to
db3f6c0
Compare
This was referenced Sep 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
Testing
We need to test it with chopsticks before merging. Try-runtime works
Anything Else?
I compared the old vs new holds and the only change was the participation
I compared the old vs new ProjectDetails and the difference was the phaseTransitionPoints being replaced with
roundDuration: { start: null end: null }
and the status changed to
SettlementStarted: Failure
in the case ofFundingFailed
, andSettlementStarted:Success
in the case ofSettlementStarted(FundingSuccessful)
Files are here: https://linear.app/polimec/issue/PLMC-601/manual-tests#comment-9b3008c7