Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Fix penpal #388

Merged
merged 1 commit into from
Sep 3, 2024
Merged

🔧 Fix penpal #388

merged 1 commit into from
Sep 3, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Aug 30, 2024 •
edited
Loading

What?

Penpal was not compiling correctly with the new sdk version

This was referenced Aug 30, 2024
Merged
Merged
Merged
Merged
Closed
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Aug 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios marked this pull request as ready for review September 2, 2024 09:36
@JuaniRios JuaniRios changed the title fix penpal 🔧 Fix penpal Sep 2, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 2, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (09/02/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

@JuaniRios JuaniRios mentioned this pull request Sep 3, 2024
Merged
This was referenced Sep 3, 2024
Closed
Merged
Merged
lrazovic
lrazovic approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@lrazovic lrazovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Initially we set everything to match the "original" penpal, but at the end we just need a runtime.

This was referenced Sep 3, 2024
Merged
Merged
Merged
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Sep 3, 2024 •
edited
Loading

Merge activity

@JuaniRios JuaniRios merged commit 7ffcbab into main Sep 3, 2024
1 check passed
@JuaniRios JuaniRios deleted the 08-30-fix_penpal branch September 3, 2024 14:13
This was referenced Sep 4, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrazovic lrazovic lrazovic approved these changes

@vstam1 vstam1 Awaiting requested review from vstam1

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuaniRios @lrazovic