-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Set balance to u128 instead of config type on pallet_funding #394
✨ Set balance to u128 instead of config type on pallet_funding #394
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @JuaniRios and the rest of your teammates on Graphite |
5eb0414
to
bedd4b9
Compare
Graphite Automations"Auto-assign PRs to author" took an action on this PR • (09/03/24)1 assignee was added to this PR based on Juan Ignacio Rios's automation. |
9649ce5
to
bf7b12e
Compare
bedd4b9
to
15aef18
Compare
bf7b12e
to
0c4ca25
Compare
15aef18
to
e6860ce
Compare
0c4ca25
to
4bab649
Compare
e6860ce
to
900d79d
Compare
4bab649
to
c78d726
Compare
900d79d
to
fb74fdb
Compare
c78d726
to
9b7c136
Compare
fb74fdb
to
425b95f
Compare
9b7c136
to
cb4d134
Compare
425b95f
to
9fc2c56
Compare
cb4d134
to
5b86ab8
Compare
9fc2c56
to
60d3f2a
Compare
5b86ab8
to
470d279
Compare
60d3f2a
to
43ac0a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the simplification this brings in terms of syntax, but I would wait for feedback from @vstam1 before merging this
470d279
to
59416da
Compare
43ac0a3
to
b321570
Compare
59416da
to
74e52d9
Compare
d95220e
to
450081d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Merge activity
|
450081d
to
56cf954
Compare
What?
Balance
config type, and replace it for u128Why?
How?
Testing?
Normal tests
Anything Else?
This will now allow us to use abs_diff for the vesting api