✨ Slashing behavior for pallet vesting

[JuaniRios]

What?

• Reduce vesting schedules of pallet-vesting after a slash is made when an evaluation is settled

Why?

• A user could have negative transferable balance if they had some tokens locked for vesting and then got slashed.

How?

• Semi-generic solution which should be easily adapted to the Polkadot SDK. PR is here.
• pallet-funding (in the future pallet-balances) accepts a tuple of items that implement a trait called on_slash.
• pallet funding calls this after slashing the evaluator (we don't use the slash interface so we call the trait directly. In the future this trait should also be called when using the slash function)
• We implement on pallet vesting the trait where we see how many tokens should be released at the moment of slashing, and then apply the slash on the remaining frozen amount. We recalculate the per_block amount to keep the same end block

Testing?

• 2 tests in the new crate on-slash-vesting
• 1 integration test

Anything Else?

• For now the trait for slashing needs to be in the same crate we implement it since we can't impl a foreign trait on a foreign crate.
• Soon we should submit a PR to polkadot-sdk where we submit this new slash interface on the tokens::fungible trait, and also add our vesting impl directly inside pallet-vesting.

[JuaniRios]

• 📒 Add Ledger support #398
• ✨ Slashing behavior for pallet vesting #396 👈
• ✨ Vesting schedule merge runtime API #395
• ✨ Set balance to u128 instead of config type on pallet_funding #394
• 🚮 Delete funding storage migrations #393
• Unneeded TODO removal #392
• 👨🏻‍💻 Tightly couple linear-release to funding pallet #391
• 🙅🏻‍♂️ Hide instantiator behind feature flag #389 : 1 other dependent PR (#390 )
• ✍🏻 Fix docs #386 : 1 other dependent PR (#387 )
• 🔖 Runtime Upgrade #383
• 💻 Runtime Benchmarks #384
• 🙅🏻‍♂️ Disallow 0CT participation #385
• 🔧 Fix penpal #388
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite

[JuaniRios]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• ✨ Slashing behavior for pallet vesting #396 👈
• ✨ Vesting schedule merge runtime API #395
• ✨ Set balance to u128 instead of config type on pallet_funding #394
• 🚮 Delete funding storage migrations #393
• Unneeded TODO removal #392
• 👨🏻‍💻 Tightly couple linear-release to funding pallet #391
• Cargo clippy + fmt #390
• 🙅🏻‍♂️ Hide instantiator behind feature flag #389
• ✍🏻 Fix docs #386 : 1 other dependent PR (#387 )
• 🔖 Runtime Upgrade #383
• 💻 Runtime Benchmarks #384
• 🙅🏻‍♂️ Disallow 0CT participation #385
• 🔧 Fix penpal #388
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite

[lrazovic]

I like it! In this round of review I mainly focused on the logic and not on the tests, I will review the tests as soon the comments are addressed.

[vstam1]

Couple of dbg statements left, but think logic looks good as is

[JuaniRios]

Merge activity

• Sep 12, 9:39 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
• Sep 12, 9:54 AM EDT: Graphite rebased this pull request as part of a merge.
• Sep 12, 9:55 AM EDT: @JuaniRios merged this pull request with Graphite.