[FIX] Active users count on @all and @here

[LucianoPierdona]

Proposed changes (including videos or screenshots)

this PR updates the old roomMembersCount to count active users instead of everyone

Issue(s)

Steps to test or reproduce

Open rocket.chat
Create a channel/room with all the members
Go to Administration > Settings > General > Notifications.
update Max Room Members Before Disabling All Message Notifications to 2 (if it matches the above requirements, if not, please use the number of active users you have in the room).
send a message with one of the active users and check if you've received a notification with the other one.

Expected Result:

Active users should've received the notification (except the one that send it).

Further comments

[codecov]

Codecov Report

Merging #25957 (6257d93) into develop (0ba7bbc) will increase coverage by 0.04%.
The diff coverage is 75.00%.

@@             Coverage Diff             @@
##           develop   #25957      +/-   ##
===========================================
+ Coverage    38.65%   38.70%   +0.04%     
===========================================
  Files          792      792              
  Lines        18892    18894       +2     
  Branches      1937     1937              
===========================================
+ Hits          7303     7313      +10     
+ Misses       11300    11294       -6     
+ Partials       289      287       -2     

Flag	Coverage Δ
e2e	38.70% <75.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[sampaiodiego]

using a $lookup here is not ideal.. large rooms will have issues performing it..

to illustrate this, I ran both codes (the old and the one) against the top 10 rooms in one of our servers and this is the result:

the code:

rooms.forEach(function(rid) {
	const now = Date.now();
	db.rocketchat_subscription.find({ rid }).count();
	print(rid + ": " + (Date.now() - now));
});

rooms.forEach(function(rid) {
	const now = Date.now();
	db.rocketchat_subscription.aggregate([
		{ $match: { rid } },
		{
			$lookup: {
				from: 'users',
				localField: 'u._id',
				foreignField: '_id',
				as: 'receiver',
			},
		},
		{ $match: { 'receiver.active': true } },
		{ $count: 'count' },
	]);
	print(rid + ": " + (Date.now() - now));
});

the results:

id	members	.count() in ms	.aggregate() in ms
room1	38072	21	4191
room2	36770	16	3833
room3	10200	4	1102
room4	3843	2	401
room5	2225	2	245
room6	1629	1	179
room7	1454	1	160
room8	1148	1	125
room9	899	0	99
room10	810	1	88

I also found out we already "archive" subscriptions of deactivated users, but for some reason we do that only for DMs (look at Subscriptions.setArchivedByUsername).. if we change that to all subscription types, we can filter for not archives.

[sampaiodiego]

so, I remembered we have a property called __rooms in IUser, this fields stores every room ID the user is joined, except DMs.. since this field is indexed, it can be used to achieve the same results without the need to use $lookup from Subscriptions..

btw, my previous comment is still valid, this is just another solution that is easier to implement.. I think we should get rid of the __rooms field in the future.. in the meantime, we can use it for this.

[LucianoPierdona]

so, I remembered we have a property called __rooms in IUser, this fields stores every room ID the user is joined, except DMs.. since this field is indexed, it can be used to achieve the same results without the need to use $lookup from Subscriptions..

btw, my previous comment is still valid, this is just another solution that is easier to implement.. I think we should get rid of the __rooms field in the future.. in the meantime, we can use it for this.

Query updated!

changes are good