Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove & Test old closeChat templates #26631

Merged
merged 9 commits into from
Aug 25, 2022
Merged

Conversation

MartinSchoeler
Copy link
Contributor

No description provided.

@MartinSchoeler MartinSchoeler requested review from a team as code owners August 19, 2022 16:47
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Aug 22, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Aug 22, 2022
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 23, 2022
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #26631 (beb1b44) into develop (12481d5) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26631      +/-   ##
===========================================
+ Coverage    38.45%   38.67%   +0.21%     
===========================================
  Files          794      792       -2     
  Lines        19002    18892     -110     
  Branches      1937     1937              
===========================================
- Hits          7308     7307       -1     
+ Misses       11401    11293     -108     
+ Partials       293      292       -1     
Flag Coverage Δ
e2e 38.67% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo merged commit 3ae6fbb into develop Aug 25, 2022
@ggazzo ggazzo deleted the closing-chat-templates branch August 25, 2022 00:25
gabriellsh added a commit that referenced this pull request Aug 26, 2022
…hreads

* 'develop' of github.com:RocketChat/Rocket.Chat: (93 commits)
  Chore: Upgrade dependencies (#26694)
  Chore: More Omnichannel tests (#26691)
  Regression: Banner - Room not found - Omnichannel room (#26693)
  [NEW] Capability to search visitors by custom fields (#26312)
  Chore: Create tests for Omnichannel admin add a custom fields (#26609)
  [FIX] Avatars of other chats disappear when they located near chat with broken avatar (#26689)
  [IMPROVE] Added identification on calls to/from existing contacts (#26334)
  Regression: invalid statistics format  (#26684)
  Regression: "Cache size is not a function" error when booting (#26683)
  [FIX] Correct IMAP configuration for email inbox (#25789)
  [FIX] Active users count on `@all` and `@here`  (#25957)
  [FIX] Autotranslate method should respect setting (#26549)
  Chore: Remove italic/bold font-style from system messages (#26655)
  Chore: Convert AppSetting to tsx (#26625)
  Chore: Remove & Test old closeChat templates (#26631)
  [IMPROVE] General federation improvements (#26150)
  [NEW] Warn admins about running multiple instances of the monolith (#26667)
  Regression: Prevent message from being temp forever (#26668)
  Regression: Add alsoSendThreadToChannel to user settings api (#26663)
  [IMPROVE] Spotlight search user results (#26599)
  ...
csuadev pushed a commit that referenced this pull request Aug 26, 2022
Co-authored-by: Guilherme Gazzo <[email protected]>
Co-authored-by: Guilherme Gazzo <[email protected]>
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eng day stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove & Test CloseRoom.html/js Remove LivechatRoomTagSelector.html/js
2 participants