Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Autotranslate method should respect setting #26549

Merged
merged 5 commits into from
Aug 25, 2022

Conversation

KevLehman
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@KevLehman KevLehman requested a review from a team August 11, 2022 21:09
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #26549 (b43d50c) into develop (8a2899f) will increase coverage by 0.53%.
The diff coverage is 0.00%.

❗ Current head b43d50c differs from pull request most recent head e90d40f. Consider uploading reports for the commit e90d40f to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26549      +/-   ##
===========================================
+ Coverage    37.96%   38.49%   +0.53%     
===========================================
  Files          778      759      -19     
  Lines        18854    18829      -25     
  Branches      1932     1459     -473     
===========================================
+ Hits          7157     7249      +92     
+ Misses       11400    11356      -44     
+ Partials       297      224      -73     
Flag Coverage Δ
e2e 38.49% <0.00%> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman requested a review from a team August 15, 2022 19:31
filipemarins
filipemarins previously approved these changes Aug 18, 2022
@ggazzo ggazzo merged commit 5f20d50 into develop Aug 25, 2022
@ggazzo ggazzo deleted the fix/autotranslate-ignoring-enabled-setting branch August 25, 2022 01:18
gabriellsh added a commit that referenced this pull request Aug 26, 2022
…hreads

* 'develop' of github.com:RocketChat/Rocket.Chat: (93 commits)
  Chore: Upgrade dependencies (#26694)
  Chore: More Omnichannel tests (#26691)
  Regression: Banner - Room not found - Omnichannel room (#26693)
  [NEW] Capability to search visitors by custom fields (#26312)
  Chore: Create tests for Omnichannel admin add a custom fields (#26609)
  [FIX] Avatars of other chats disappear when they located near chat with broken avatar (#26689)
  [IMPROVE] Added identification on calls to/from existing contacts (#26334)
  Regression: invalid statistics format  (#26684)
  Regression: "Cache size is not a function" error when booting (#26683)
  [FIX] Correct IMAP configuration for email inbox (#25789)
  [FIX] Active users count on `@all` and `@here`  (#25957)
  [FIX] Autotranslate method should respect setting (#26549)
  Chore: Remove italic/bold font-style from system messages (#26655)
  Chore: Convert AppSetting to tsx (#26625)
  Chore: Remove & Test old closeChat templates (#26631)
  [IMPROVE] General federation improvements (#26150)
  [NEW] Warn admins about running multiple instances of the monolith (#26667)
  Regression: Prevent message from being temp forever (#26668)
  Regression: Add alsoSendThreadToChannel to user settings api (#26663)
  [IMPROVE] Spotlight search user results (#26599)
  ...
@sampaiodiego sampaiodiego added this to the 5.0.6 milestone Aug 30, 2022
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
@KevLehman KevLehman modified the milestones: 5.0.6, 5.1.0 Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants