-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: invalid statistics format #26684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierre-lehnen-rc
approved these changes
Aug 25, 2022
pierre-lehnen-rc
changed the title
[FIX] installedAt field changed back to ISO string
Regression: invalid statistics format
Aug 25, 2022
ggazzo
approved these changes
Aug 25, 2022
KevLehman
approved these changes
Aug 25, 2022
Codecov Report
@@ Coverage Diff @@
## develop #26684 +/- ##
===========================================
+ Coverage 38.66% 38.71% +0.05%
===========================================
Files 792 792
Lines 18894 18894
Branches 1937 1937
===========================================
+ Hits 7305 7315 +10
+ Misses 11302 11293 -9
+ Partials 287 286 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
added
stat: QA skipped
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: needs QA
labels
Aug 25, 2022
ggazzo
changed the title
Regression: invalid statistics format
Regression: invalid statistics format
Aug 25, 2022
gabriellsh
added a commit
that referenced
this pull request
Aug 26, 2022
…hreads * 'develop' of github.com:RocketChat/Rocket.Chat: (93 commits) Chore: Upgrade dependencies (#26694) Chore: More Omnichannel tests (#26691) Regression: Banner - Room not found - Omnichannel room (#26693) [NEW] Capability to search visitors by custom fields (#26312) Chore: Create tests for Omnichannel admin add a custom fields (#26609) [FIX] Avatars of other chats disappear when they located near chat with broken avatar (#26689) [IMPROVE] Added identification on calls to/from existing contacts (#26334) Regression: invalid statistics format (#26684) Regression: "Cache size is not a function" error when booting (#26683) [FIX] Correct IMAP configuration for email inbox (#25789) [FIX] Active users count on `@all` and `@here` (#25957) [FIX] Autotranslate method should respect setting (#26549) Chore: Remove italic/bold font-style from system messages (#26655) Chore: Convert AppSetting to tsx (#26625) Chore: Remove & Test old closeChat templates (#26631) [IMPROVE] General federation improvements (#26150) [NEW] Warn admins about running multiple instances of the monolith (#26667) Regression: Prevent message from being temp forever (#26668) Regression: Add alsoSendThreadToChannel to user settings api (#26663) [IMPROVE] Spotlight search user results (#26599) ...
csuadev
pushed a commit
that referenced
this pull request
Aug 26, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
This property was breaking statistics collection, it expected ISO strings for dates.
Steps to test or reproduce
Clone the pr, start the workspace, notice the lack of messages about statistics being broken.
Further comments