feat: Contextualbar resizable

[dougfabris]

Proposed changes (including videos or screenshots)

Issue(s)

Closes RocketChat/feature-requests#159

Steps to test or reproduce

Further comments

CORE-282

[changeset-bot]

🦋 Changeset detected

Latest commit: c0b9706

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages

Name	Type
@rocket.chat/meteor	Minor
@rocket.chat/core-typings	Minor
@rocket.chat/rest-typings	Minor
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/gazzodown	Major
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Major
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/fuselage-ui-kit	Major
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Major
@rocket.chat/ui-client	Major
@rocket.chat/ui-video-conf	Major
@rocket.chat/uikit-playground	Patch
@rocket.chat/web-ui-registration	Major
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 54.74%. Comparing base (ec544d6) to head (167df1d).
Report is 1 commits behind head on develop.

❗ Current head 167df1d differs from pull request most recent head c0b9706. Consider uploading reports for the commit c0b9706 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #29461      +/-   ##
===========================================
- Coverage    54.83%   54.74%   -0.10%     
===========================================
  Files         2302     2303       +1     
  Lines        50828    50794      -34     
  Branches     10413    10388      -25     
===========================================
- Hits         27874    27805      -69     
- Misses       20443    20512      +69     
+ Partials      2511     2477      -34     

Flag	Coverage Δ
unit	75.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[Gummikavalier]

A suggestion: Currently we run the separate thread view as big as this with Custom CSS:

We hope that this separated view could be stretched from its default 50:50 form factor to something like in the picture.

At this custom size it is much more pleasing to read and focus on the discussion at hand.

[dougfabris]

@Gummikavalier Thanks for the heads up, we'll consider it on delivering this feature!

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is not mergeable
  Please fix the issues and try again
  If you have any trouble, please check the PR guidelines

[Gummikavalier]

This one is currently broken in RC 6.8.0; Hovering mouse over the contextual bar edge simply does nothing. I cleared our custom CSS first for this test. I tested also at open.rocket.chat with the same result.

[dougfabris]

@Gummikavalier it was released as a feature preview, in order to be able to use it you have to enable the feature under User Account > Feature preview. And of course, the feature preview should be active on the workspace also (it's active on open.rocket.chat, so you can check this feature there).

[Gummikavalier]

@dougfabris Ahh, I eyeballed for it under admin settings but couldn't find it first. Found the Feature preview now.

Resizing works a treat now. Thanks! 😍

[dougfabris]

@Gummikavalier We're running some experiments, would appreciate your feedback for the whole feature and mainly for the possibility to not having the thread expanded anymore, since user can resize for all contexts

[Gummikavalier]

@dougfabris I'll be updating one production system this week to RC 6.8.0 so we may get some comments after that.

A forewarning though; We've spoiled our users for years with that a lot more extended custom Expand thread view mode I mentioned earlier here. So it is not likely many will switch from expand thread view to to regular thread view due to latter having only 50% max size. 🤔

Most rejoicing would be heard from option to resize both thread views. And extra hugs from ability to tune the channel listing bar as well. 🤗

(Yes, appetite grows from these small tasters. 😁 )

[dougfabris]

@Gummikavalier Thanks for replying! I've been planning to discuss with the design team the ability to increase the max size over 50%, do you think with this ability, your users will still miss the extended view? I think the main goal here is to have a unique mechanism to improve the contextual bar view using personalization

[Gummikavalier]

@dougfabris Actually even my personal preference is the Expanded view as it darkens the main channel and focuses the eyes on the thread. It stands out better and the general esthetics is less cluttered. Meaning that the user is more focused to the discussion.

Several exactly same looking parallel text columns is quite confusing (to me at least). Looking at Discord often makes me vince how bad it can be. 🤢

With regular view if you were able to increase the size to higher than 50%, it'd probably also reformat the messages in the main channel view quite thin. Not sure, would probably need some prototyping to see how it'd work.

If only regular mode is the way to go in the future to simplify design, maybe some coloring or hue changes to either main channel or thread background could help with that.

[dougfabris]

@Gummikavalier Yeah, maybe a focus mode option that makes the main channel darker instead of extended. Thank your for bring your opinion, I will add it to the discussion with the design team

[Gummikavalier]

@dougfabris No problem and thank you. Regarding on comments on resized contextual bar; it is great that particularly message search, threads listing and members list views can be extended; it making them easier to read.

[Gummikavalier]

@dougfabris FYI: Not reporting this as an official bug, as the feature is in preview. If you hover the mouse in expanded view over a line where the divider would be in collapsed view, it shows through as a blue line.

This flashes to the uses every now and then when the mouse travels exactly over the line. Probably not worth fixing if expanded view would be going away, though.

[dougfabris]

@Gummikavalier This is a know issue indeed, thank you for reporting. But yeah, we have to check first about the usage of the extended view. If we doesn't keep it, there is no why fix it.