Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move imported Apps to proxy #32142

Merged
merged 1 commit into from
Apr 5, 2024
Merged

chore: move imported Apps to proxy #32142

merged 1 commit into from
Apr 5, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Apr 5, 2024 •
edited
Loading

The old replace didn't work for imports that happened before register, if a package had a dynamic import in the middle this could be a problem as all packages are loaded in parallel. Today with fiber this doesn't happen, but it's still wrong

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 5, 2024 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 289139b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov Codecov
Copy link

codecov bot commented Apr 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 27.27273% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 54.75%. Comparing base (0fcf1f0) to head (289139b).
Report is 10 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32142      +/-   ##
===========================================
- Coverage    54.76%   54.75%   -0.01%     
===========================================
  Files         2298     2303       +5     
  Lines        50779    50833      +54     
  Branches     10394    10413      +19     
===========================================
+ Hits         27807    27832      +25     
- Misses       20468    20489      +21     
- Partials      2504     2512       +8
Flag Coverage Δ
e2e 53.71% <ø> (+<0.01%) ⬆️
e2e-api 40.00% <27.27%> (-0.02%) ⬇️
unit 75.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added this to the 6.8 milestone Apr 5, 2024
@ggazzo ggazzo marked this pull request as ready for review April 5, 2024 18:20
@ggazzo ggazzo requested review from a team as code owners April 5, 2024 18:20
@pierre-lehnen-rc pierre-lehnen-rc added the stat: QA assured Means it has been tested and approved by a company insider label Apr 5, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 5, 2024
@ggazzo ggazzo merged commit a7823c1 into develop Apr 5, 2024
45 checks passed
@ggazzo ggazzo deleted the chore/app-proxy branch April 5, 2024 19:13
gabriellsh added a commit that referenced this pull request Apr 9, 2024
@gabriellsh
Merge branch 'develop' into attachmentMessage
6dad990 
 Via GitHub (2) and Guilherme Gazzo (1)
* develop: (40 commits)
  chore: Fix some check/lint warnings (#32048)
  Revert "fix!: api login should not suggest which credential is wrong" (#32156)
  test: Prevent playwright from unselecting options by mistake (#32158)
  chore(meteor/packages): apply code style (#32145)
  fix: New messages export overwrites previous one from the same day when using Amazon S3 (#32062)
  Release 6.7.0
  chore: bump to 6.8.0 (#32153)
  chore: remove unused onStartup function (#32149)
  Release 6.7.0-rc.4
  chore: remove collections when db watcher is disabled (#32150)
  chore: Bump Apps-Engine version (#32144)
  regression(fuselage-ui-kit): Use default translation namespace for `-core` apps (#32105)
  regression(fuselage-ui-kit): Use default translation namespace for `-core` apps (#32105)
  chore: move imported `Apps` to proxy (#32142)
  feat: allowing forward to offline dep (#31976)
  ci: fix services container not building in build step (#32075)
  feat: `Contextualbar` resizable (#29461)
  fix: Missing space between name and user name on system messages (#32136)
  fix: livechat room desync on different windows (#32135)
  fix: livechat room desync on different windows (#32135)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@pierre-lehnen-rc pierre-lehnen-rc pierre-lehnen-rc approved these changes

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
6.8
Development

Successfully merging this pull request may close these issues.
3 participants
@ggazzo @sampaiodiego @pierre-lehnen-rc