Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(meteor/packages): apply code style #32145

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Apr 6, 2024

just change quotes and spacing, better now than later, as soon as we have some real modification the diff will be easier to visualize

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Apr 6, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Apr 6, 2024

⚠️ No Changeset found

Latest commit: 3e4f4ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.77%. Comparing base (a316c2b) to head (3e4f4ea).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32145      +/-   ##
===========================================
+ Coverage    53.67%   54.77%   +1.10%     
===========================================
  Files         2223     2299      +76     
  Lines        49680    50784    +1104     
  Branches     10195    10406     +211     
===========================================
+ Hits         26666    27819    +1153     
+ Misses       20594    20459     -135     
- Partials      2420     2506      +86     
Flag Coverage Δ
e2e 53.70% <ø> (+2.11%) ⬆️
unit 75.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo force-pushed the chore/meteor-packages branch 2 times, most recently from 2482079 to 1fbdb10 Compare April 6, 2024 01:41
@ggazzo ggazzo marked this pull request as ready for review April 8, 2024 21:40
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Apr 8, 2024
@ggazzo ggazzo added this to the 6.8 milestone Apr 8, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 8, 2024
@ggazzo ggazzo merged commit 474589f into develop Apr 8, 2024
46 checks passed
@ggazzo ggazzo deleted the chore/meteor-packages branch April 8, 2024 22:00
gabriellsh added a commit that referenced this pull request Apr 9, 2024
 Via GitHub (2) and Guilherme Gazzo (1)
* develop: (40 commits)
  chore: Fix some check/lint warnings (#32048)
  Revert "fix!: api login should not suggest which credential is wrong" (#32156)
  test: Prevent playwright from unselecting options by mistake (#32158)
  chore(meteor/packages): apply code style (#32145)
  fix: New messages export overwrites previous one from the same day when using Amazon S3 (#32062)
  Release 6.7.0
  chore: bump to 6.8.0 (#32153)
  chore: remove unused onStartup function (#32149)
  Release 6.7.0-rc.4
  chore: remove collections when db watcher is disabled (#32150)
  chore: Bump Apps-Engine version (#32144)
  regression(fuselage-ui-kit): Use default translation namespace for `-core` apps (#32105)
  regression(fuselage-ui-kit): Use default translation namespace for `-core` apps (#32105)
  chore: move imported `Apps` to proxy (#32142)
  feat: allowing forward to offline dep (#31976)
  ci: fix services container not building in build step (#32075)
  feat: `Contextualbar` resizable (#29461)
  fix: Missing space between name and user name on system messages (#32136)
  fix: livechat room desync on different windows (#32135)
  fix: livechat room desync on different windows (#32135)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants