fix: New messages export overwrites previous one from the same day when using Amazon S3 #32062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in external storage services
🦋 Changeset detectedLatest commit: 8f60224 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32062 +/- ##
===========================================
+ Coverage 53.67% 54.80% +1.12%
===========================================
Files 2223 2301 +78
Lines 49680 50793 +1113
Branches 10195 10409 +214
===========================================
+ Hits 26666 27835 +1169
+ Misses 20594 20453 -141
- Partials 2420 2505 +85
Flags with carried forward coverage won't be shown. Click here to find out more. |
matheusbsilva137
changed the title
MarcosSpessatto
requested changes
Mar 26, 2024
….com/RocketChat/Rocket.Chat into fix/export-messages-replace-files-s3
debdutdeb
reviewed
Mar 26, 2024
Co-authored-by: Debdut Chakraborty <[email protected]>
MarcosSpessatto
requested changes
Mar 27, 2024
apps/meteor/tests/unit/server/lib/dataExport/uploadZipFile.spec.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/unit/server/lib/dataExport/uploadZipFile.spec.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/unit/server/lib/dataExport/uploadZipFile.spec.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/unit/server/lib/dataExport/uploadZipFile.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Marcos Spessatto Defendi <[email protected]>
MarcosSpessatto
approved these changes
Mar 27, 2024
KevLehman
approved these changes
Mar 27, 2024
jessicaschelly
added
stat: QA assured
|
Looks like this PR is ready to merge! 🎉 |
|
Looks like this PR is not ready to merge, because of the following issues:
|
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Apr 9, 2024
Via GitHub (2) and Guilherme Gazzo (1) * develop: (40 commits) chore: Fix some check/lint warnings (#32048) Revert "fix!: api login should not suggest which credential is wrong" (#32156) test: Prevent playwright from unselecting options by mistake (#32158) chore(meteor/packages): apply code style (#32145) fix: New messages export overwrites previous one from the same day when using Amazon S3 (#32062) Release 6.7.0 chore: bump to 6.8.0 (#32153) chore: remove unused onStartup function (#32149) Release 6.7.0-rc.4 chore: remove collections when db watcher is disabled (#32150) chore: Bump Apps-Engine version (#32144) regression(fuselage-ui-kit): Use default translation namespace for `-core` apps (#32105) regression(fuselage-ui-kit): Use default translation namespace for `-core` apps (#32105) chore: move imported `Apps` to proxy (#32142) feat: allowing forward to offline dep (#31976) ci: fix services container not building in build step (#32075) feat: `Contextualbar` resizable (#29461) fix: Missing space between name and user name on system messages (#32136) fix: livechat room desync on different windows (#32135) fix: livechat room desync on different windows (#32135) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Set Amazon S3 as the Storage Type and sequentially export multiple rooms as files.
Current behavior: by accessing the oldest export sent by email and clicking the link, the downloaded file is actually related to the latest export.
Expected behavior: each downloaded file should contain its corresponding export, no overwrites should be made.
Further comments
SUP-522