Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create contact endpoint #32693

Merged
merged 55 commits into from
Aug 23, 2024
Merged

feat: create contact endpoint #32693

merged 55 commits into from
Aug 23, 2024

Conversation

tapiarafael
Copy link
Member

@tapiarafael tapiarafael commented Jun 27, 2024

Proposed changes (including videos or screenshots)

Implement the entity contact (collection rocketchat_livechat_contact) to the omnichannel and an endpoint to be able to create a contact manually.

[POST] api/v1/omnichannel/contacts
request example:

{
	"name": "Contact 1",
	"emails": [
		"[email protected]"
	],
	"phones": [
		"5511999999999"
	],
}

response example:

{
	"contactId": "668830239ac5cb4b15229d6d",
	"success": true
}

Issue(s)

Steps to test or reproduce

  1. create a contact using the new endpoint mentioned above;
  2. check on the collection;

Further comments

SCI-33

Copy link
Contributor

dionisio-bot bot commented Jun 27, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 27, 2024

🦋 Changeset detected

Latest commit: c79fe52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/model-typings Minor
@rocket.chat/models Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/instance-status Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 40.74074% with 16 lines in your changes missing coverage. Please review.

Project coverage is 59.33%. Comparing base (27f9249) to head (c79fe52).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32693      +/-   ##
===========================================
- Coverage    59.38%   59.33%   -0.06%     
===========================================
  Files         2547     2548       +1     
  Lines        63221    63320      +99     
  Branches     14214    14248      +34     
===========================================
+ Hits         37543    37570      +27     
- Misses       22973    23043      +70     
- Partials      2705     2707       +2     
Flag Coverage Δ
unit 75.47% <40.74%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tapiarafael tapiarafael marked this pull request as ready for review June 28, 2024 12:21
@tapiarafael tapiarafael requested review from a team as code owners June 28, 2024 12:21
.changeset/sixty-spoons-own.md Outdated Show resolved Hide resolved
apps/meteor/app/livechat/server/api/v1/contact.ts Outdated Show resolved Hide resolved
apps/meteor/app/livechat/server/api/v1/contact.ts Outdated Show resolved Hide resolved
apps/meteor/app/livechat/server/lib/Contacts.ts Outdated Show resolved Hide resolved
apps/meteor/app/livechat/server/lib/Contacts.ts Outdated Show resolved Hide resolved
apps/meteor/app/livechat/server/lib/Contacts.ts Outdated Show resolved Hide resolved
apps/meteor/app/livechat/server/lib/Contacts.ts Outdated Show resolved Hide resolved
apps/meteor/tests/end-to-end/api/livechat/contacts.ts Outdated Show resolved Hide resolved
tassoevan
tassoevan previously approved these changes Aug 8, 2024
@tapiarafael tapiarafael added the stat: QA assured Means it has been tested and approved by a company insider label Aug 23, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 23, 2024
@kodiakhq kodiakhq bot merged commit 927710d into develop Aug 23, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the feat/create-contact-endpoint branch August 23, 2024 13:49
gabriellsh added a commit that referenced this pull request Sep 2, 2024
…ove/threadMetrics

* 'develop' of github.com:RocketChat/Rocket.Chat: (49 commits)
  feat: add `sidepanelNavigation` to Feature preview list (#33156)
  refactor: Realtime Monitoring Counters to TS (#33182)
  fix: restore tooltips to units Multiselect (#33174)
  test: Add unit test for RoomMenu options (#32891)
  chore: remove notifyListener call that was causing startup issues (#33154)
  fix: Multi-step modals closing unexpectedly (#33158)
  Revert "refactor: Realtime Monitoring Counters to TS" (#33170)
  refactor: Realtime Monitoring Counters to TS (#33166)
  refactor: Uses `source` instead of `room` to render the `OmnichannelRoomIcon` (#33118)
  refactor: Realtime Monitoring Overviews to TS (#33167)
  test: Add e2e tests for teams multi-step modals (#33168)
  feat: add Advanced settings accordion to `EditRoomInfo` (#33114)
  chore: Revive Livechat Storybook (#33137)
  refactor: Realtime `Doughnout Charts` to TS (#33092)
  feat: create contact endpoint (#32693)
  chore: remove left streaming code (#33039)
  fix: show only relevant userInfoActions for mentioned non-members (#31525)
  feat: Setting for enabling files encryption and fix whitelist media types stopping E2EE uploads (#33003)
  refactor: Replace proxy functions from `LivechatTyped` class with direct calls (#33110)
  Revert "fix: Inconsistent Markdown Formatting in Custom Status Field" (#33127)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants