Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sidepanelNavigation to Feature preview list #33156

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Aug 26, 2024

SIDE-148

Proposed changes (including videos or screenshots)

This PR prepares the feature preview configuration for the sidepanel navigation

  • add sidepanelNavigation to feature preview list
  • for now, this feature should not appear on the list, so it's set to enabled: false

Issue(s)

Steps to test or reproduce

Further comments

@juliajforesti juliajforesti added this to the 6.13 milestone Aug 26, 2024
Copy link
Contributor

dionisio-bot bot commented Aug 26, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.13.0, but it targets 6.12.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: c6356e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/ui-client Major
@rocket.chat/i18n Minor
@rocket.chat/meteor Minor
@rocket.chat/gazzodown Major
@rocket.chat/web-ui-registration Major
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.33%. Comparing base (0f5a39e) to head (c6356e9).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33156   +/-   ##
========================================
  Coverage    59.33%   59.33%           
========================================
  Files         2546     2546           
  Lines        63245    63245           
  Branches     14220    14220           
========================================
  Hits         37527    37527           
  Misses       23016    23016           
  Partials      2702     2702           
Flag Coverage Δ
unit 75.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti marked this pull request as ready for review August 29, 2024 21:12
@juliajforesti juliajforesti requested a review from a team as a code owner August 29, 2024 21:12
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Aug 29, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 29, 2024
@kodiakhq kodiakhq bot merged commit bb94c9c into develop Aug 30, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the feat/sidepanelNavigation-feature-preview branch August 30, 2024 03:55
gabriellsh added a commit that referenced this pull request Sep 2, 2024
…ove/threadMetrics

* 'develop' of github.com:RocketChat/Rocket.Chat: (49 commits)
  feat: add `sidepanelNavigation` to Feature preview list (#33156)
  refactor: Realtime Monitoring Counters to TS (#33182)
  fix: restore tooltips to units Multiselect (#33174)
  test: Add unit test for RoomMenu options (#32891)
  chore: remove notifyListener call that was causing startup issues (#33154)
  fix: Multi-step modals closing unexpectedly (#33158)
  Revert "refactor: Realtime Monitoring Counters to TS" (#33170)
  refactor: Realtime Monitoring Counters to TS (#33166)
  refactor: Uses `source` instead of `room` to render the `OmnichannelRoomIcon` (#33118)
  refactor: Realtime Monitoring Overviews to TS (#33167)
  test: Add e2e tests for teams multi-step modals (#33168)
  feat: add Advanced settings accordion to `EditRoomInfo` (#33114)
  chore: Revive Livechat Storybook (#33137)
  refactor: Realtime `Doughnout Charts` to TS (#33092)
  feat: create contact endpoint (#32693)
  chore: remove left streaming code (#33039)
  fix: show only relevant userInfoActions for mentioned non-members (#31525)
  feat: Setting for enabling files encryption and fix whitelist media types stopping E2EE uploads (#33003)
  refactor: Replace proxy functions from `LivechatTyped` class with direct calls (#33110)
  Revert "fix: Inconsistent Markdown Formatting in Custom Status Field" (#33127)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants