refactor: Uses source instead of room to render the OmnichannelRoomIcon
#33118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33118 +/- ##
===========================================
+ Coverage 59.31% 59.33% +0.01%
===========================================
Files 2548 2547 -1
Lines 63289 63258 -31
Branches 14233 14221 -12
===========================================
- Hits 37543 37531 -12
+ Misses 23042 23025 -17
+ Partials 2704 2702 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
dougfabris
force-pushed
the
refactor/omnichannelRoomIcon
branch
2 times, most recently
from
6cddcaf
to
c055c89
Compare
dougfabris
force-pushed
the
refactor/omnichannelRoomIcon
branch
from
c055c89
to
08dc7fd
Compare
ggazzo
approved these changes
Aug 27, 2024
ggazzo
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Sep 2, 2024
…ove/threadMetrics * 'develop' of github.com:RocketChat/Rocket.Chat: (49 commits) feat: add `sidepanelNavigation` to Feature preview list (#33156) refactor: Realtime Monitoring Counters to TS (#33182) fix: restore tooltips to units Multiselect (#33174) test: Add unit test for RoomMenu options (#32891) chore: remove notifyListener call that was causing startup issues (#33154) fix: Multi-step modals closing unexpectedly (#33158) Revert "refactor: Realtime Monitoring Counters to TS" (#33170) refactor: Realtime Monitoring Counters to TS (#33166) refactor: Uses `source` instead of `room` to render the `OmnichannelRoomIcon` (#33118) refactor: Realtime Monitoring Overviews to TS (#33167) test: Add e2e tests for teams multi-step modals (#33168) feat: add Advanced settings accordion to `EditRoomInfo` (#33114) chore: Revive Livechat Storybook (#33137) refactor: Realtime `Doughnout Charts` to TS (#33092) feat: create contact endpoint (#32693) chore: remove left streaming code (#33039) fix: show only relevant userInfoActions for mentioned non-members (#31525) feat: Setting for enabling files encryption and fix whitelist media types stopping E2EE uploads (#33003) refactor: Replace proxy functions from `LivechatTyped` class with direct calls (#33110) Revert "fix: Inconsistent Markdown Formatting in Custom Status Field" (#33127) ...
abhinavkrin
pushed a commit
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
It allows getting the Omnichannel room icons without being in the room context
Issue(s)
Steps to test or reproduce
Further comments