-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow custom fields on messages to be updated even if msg
prop is not updated (via API)
#32791
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 53c93c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32791 +/- ##
========================================
Coverage 54.98% 54.98%
========================================
Files 2596 2596
Lines 55971 55971
Branches 11585 11585
========================================
Hits 30775 30775
Misses 22553 22553
Partials 2643 2643
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a PR description?
msg
prop is not updated (via API)text
prop is not updated (via API)
text
prop is not updated (via API)msg
prop is not updated (via API)
…Chat into improve/threadMetrics * 'improve/threadMetrics' of github.com:RocketChat/Rocket.Chat: ci: Bump `@actions/download-artifact` and `@actions/upload-artifact` (#32930) fix: Allow custom fields on messages to be updated even if `msg` prop is not updated (via API) (#32791) test: Make Omnichannel jobs run every 3 secs on CI instead of 1 min (#32967) ci: only rebuild docker if event is pull request and is from outside (#32997) ci: remove tmp files (#32996) test: Mock `dns.lookup` on `checkUrlForSsrf` tests (#32995) chore: `FilterByText` component sanitization (#32957) chore: Renders back button through prop in admin settings (#32987) feat: add `sidepanel` to teams api (#32868) chore: don't mark room as read after sending message (#32941) chore: replace `dtinth/setup-github-actions-caching-for-turbo` to use `rhark… (#32990)
Proposed changes (including videos or screenshots)
Fixed a behavior when updating messages that prevented the
customFields
prop from being updated if there were no changes to themsg
property. Now,customFields
will be always updated on message update even ifmsg
doesn't changeIssue(s)
SUP-621
Steps to test or reproduce
Further comments