Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace dtinth/setup-github-actions-caching-for-turbo to use `rhark… #32990

Merged
merged 2 commits into from
Aug 6, 2024
Merged

chore: replace dtinth/setup-github-actions-caching-for-turbo to use `rhark… #32990

merged 2 commits into from
Aug 6, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Aug 6, 2024 •
edited
Loading

…or/[email protected]`

the action was deprecated and this one suggested as a replacement

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 6, 2024 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 6, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 72078c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov Codecov
Copy link

codecov bot commented Aug 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.00%. Comparing base (cf778f1) to head (72078c0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32990   +/-   ##
========================================
  Coverage    55.00%   55.00%           
========================================
  Files         2596     2596           
  Lines        56006    56006           
  Branches     11589    11589           
========================================
  Hits         30804    30804           
  Misses       22559    22559           
  Partials      2643     2643
Flag Coverage Δ
unit 73.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review August 6, 2024 06:54
@ggazzo ggazzo requested a review from a team as a code owner August 6, 2024 06:54
@ggazzo ggazzo added this to the 6.12 milestone Aug 6, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Aug 6, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 6, 2024
@kodiakhq kodiakhq bot merged commit b4d8c14 into develop Aug 6, 2024
50 checks passed
@kodiakhq kodiakhq bot deleted the chore/turbo-cache-action branch August 6, 2024 14:25
gabriellsh added a commit that referenced this pull request Aug 8, 2024
@gabriellsh
Merge branch 'improve/threadMetrics' of github.com:RocketChat/Rocket.…
a7f92ae 
…Chat into improve/threadMetrics

* 'improve/threadMetrics' of github.com:RocketChat/Rocket.Chat:
  ci: Bump `@actions/download-artifact` and `@actions/upload-artifact` (#32930)
  fix: Allow custom fields on messages to be updated even if `msg` prop is not updated (via API) (#32791)
  test: Make Omnichannel jobs run every 3 secs on CI instead of 1 min (#32967)
  ci: only rebuild docker if event is pull request and is from outside (#32997)
  ci: remove tmp files (#32996)
  test: Mock `dns.lookup` on `checkUrlForSsrf` tests (#32995)
  chore: `FilterByText` component sanitization (#32957)
  chore: Renders back button through prop in admin settings (#32987)
  feat: add `sidepanel` to teams api (#32868)
  chore: don't mark room as read after sending message (#32941)
  chore: replace `dtinth/setup-github-actions-caching-for-turbo` to use `rhark… (#32990)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
6.12
Development

Successfully merging this pull request may close these issues.
2 participants
@ggazzo @sampaiodiego