Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: FilterByText component sanitization #32957

Merged
merged 6 commits into from
Aug 6, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Aug 1, 2024

Proposed changes (including videos or screenshots)

  • It removes unnecessary button props in FilterByText
  • Fixes margins inside FilterByText and visual details to compensate in necessary components
  • Removes unnecessary useEffect causing infinity loop on non-memoized function calls

Issue(s)

Steps to test or reproduce

Further comments

SCI-62

Copy link
Contributor

dionisio-bot bot commented Aug 1, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 1, 2024

⚠️ No Changeset found

Latest commit: 097392f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.96%. Comparing base (0c919db) to head (e57bf2d).
Report is 26 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32957      +/-   ##
===========================================
- Coverage    54.97%   54.96%   -0.02%     
===========================================
  Files         2595     2595              
  Lines        55964    55942      -22     
  Branches     11578    11575       -3     
===========================================
- Hits         30766    30747      -19     
+ Misses       22555    22552       -3     
  Partials      2643     2643              
Flag Coverage Δ
unit 72.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review August 1, 2024 20:35
@dougfabris dougfabris requested a review from a team as a code owner August 1, 2024 20:35
@dougfabris dougfabris added this to the 6.12 milestone Aug 1, 2024
MartinSchoeler
MartinSchoeler previously approved these changes Aug 1, 2024
Copy link
Contributor

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Nice

yarn.lock Outdated Show resolved Hide resolved
@dougfabris dougfabris force-pushed the chore/sanitize-filter-by-text branch from e9f5409 to e57bf2d Compare August 2, 2024 21:01
@dougfabris dougfabris changed the title chore: Remove FilterByText button props chore: FilterByText component sanitization Aug 2, 2024
@gabriellsh gabriellsh added the stat: QA assured Means it has been tested and approved by a company insider label Aug 6, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 6, 2024
@kodiakhq kodiakhq bot merged commit 2c72a26 into develop Aug 6, 2024
47 checks passed
@kodiakhq kodiakhq bot deleted the chore/sanitize-filter-by-text branch August 6, 2024 21:01
gabriellsh added a commit that referenced this pull request Aug 8, 2024
…Chat into improve/threadMetrics

* 'improve/threadMetrics' of github.com:RocketChat/Rocket.Chat:
  ci: Bump `@actions/download-artifact` and `@actions/upload-artifact` (#32930)
  fix: Allow custom fields on messages to be updated even if `msg` prop is not updated (via API) (#32791)
  test: Make Omnichannel jobs run every 3 secs on CI instead of 1 min (#32967)
  ci: only rebuild docker if event is pull request and is from outside (#32997)
  ci: remove tmp files (#32996)
  test: Mock `dns.lookup` on `checkUrlForSsrf` tests (#32995)
  chore: `FilterByText` component sanitization (#32957)
  chore: Renders back button through prop in admin settings (#32987)
  feat: add `sidepanel` to teams api (#32868)
  chore: don't mark room as read after sending message (#32941)
  chore: replace `dtinth/setup-github-actions-caching-for-turbo` to use `rhark… (#32990)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants