-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sidepanel
to teams api
#32868
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: c5a2af3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32868 +/- ##
===========================================
- Coverage 55.00% 54.93% -0.07%
===========================================
Files 2596 2598 +2
Lines 56005 56071 +66
Branches 11589 11598 +9
===========================================
+ Hits 30803 30804 +1
- Misses 22559 22637 +78
+ Partials 2643 2630 -13
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, can you please add more context in the PR description about how this change should work?
sidepanel
to teams createsidepanel
to teams api
apps/meteor/app/channel-settings/server/methods/saveRoomSettings.ts
Outdated
Show resolved
Hide resolved
apps/meteor/app/channel-settings/server/methods/saveRoomSettings.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Matheus Barbosa Silva <[email protected]>
Co-authored-by: Matheus Barbosa Silva <[email protected]>
…Chat into improve/threadMetrics * 'improve/threadMetrics' of github.com:RocketChat/Rocket.Chat: ci: Bump `@actions/download-artifact` and `@actions/upload-artifact` (#32930) fix: Allow custom fields on messages to be updated even if `msg` prop is not updated (via API) (#32791) test: Make Omnichannel jobs run every 3 secs on CI instead of 1 min (#32967) ci: only rebuild docker if event is pull request and is from outside (#32997) ci: remove tmp files (#32996) test: Mock `dns.lookup` on `checkUrlForSsrf` tests (#32995) chore: `FilterByText` component sanitization (#32957) chore: Renders back button through prop in admin settings (#32987) feat: add `sidepanel` to teams api (#32868) chore: don't mark room as read after sending message (#32941) chore: replace `dtinth/setup-github-actions-caching-for-turbo` to use `rhark… (#32990)
SIDE-134
Proposed changes (including videos or screenshots)
The
new navigation
feature adds the possibility of opening a sidepanel when opening a Team.The sidepanel can list the team's channels and/or discussions.
This will be a configuration for each team when creating or editing.
This PR prepares the api structure for the upcoming UI.
teams.create
rooms.saveRoomSettings
Issue(s)
Steps to test or reproduce
Further comments