Fix change config yml loc #1042
Commits on Jul 2, 2022
-
fix(config): unifying config manipulation
All config manipulation now go through amend_golem_config. This allows to be sure that the !expr are not lost Close ThinkR-open#709
-
-
-
feature(creation): create golem only set the app name
There is no need to set things that are already set in the yaml
-
feat(create_golem): No name change in the YAML
The name is already set by the function that gsub in the files so there is no need to do it one extra time
-
fix(option-setting): don't change to expr before passing to set_golem…
…_wd() The attr is not set before being passed to set_golem_wd() in set_golem_options()
Commits on Jul 4, 2022
-
chore(file): file splitting & renaming
The yaml manimpulation functions are now separated in various files
-
fix(config): Use the correct env var in get_golem_*
The get_golem_* didn't rely on the GOLEM_CONFIG_ACTIVE env_var
-
-
-
feat(config): get_golem_* now tries to guess if not found in yaml
+ get_golem_wd tries golem::pkg_path + get_golem_name tries pkg_name + get_golem_version tries pkg_version
Commits on Jul 13, 2022
-
feat: add support for docker & {renv} (ThinkR-open#882)
Co-authored-by: Colin Fay <[email protected]>
Commits on Aug 8, 2022
-
-
feat: add support for docker & {renv} (ThinkR-open#882) (ThinkR-open#889
) Co-authored-by: Colin Fay <[email protected]> Co-authored-by: vincent guyader <[email protected]>
-
-
bug: fixed bug with check_installed
Hotfix because of the dirty way we released version 0.3.3
-
-
-
Commits on Aug 9, 2022
-
-
-
-
-
-
-
-
fix(config): unifying config manipulation
All config manipulation now go through amend_golem_config. This allows to be sure that the !expr are not lost Close ThinkR-open#709
-
-
-
feature(creation): create golem only set the app name
There is no need to set things that are already set in the yaml
-
feat(create_golem): No name change in the YAML
The name is already set by the function that gsub in the files so there is no need to do it one extra time
-
fix(option-setting): don't change to expr before passing to set_golem…
…_wd() The attr is not set before being passed to set_golem_wd() in set_golem_options()
-
chore(file): file splitting & renaming
The yaml manimpulation functions are now separated in various files
-
fix(config): Use the correct env var in get_golem_*
The get_golem_* didn't rely on the GOLEM_CONFIG_ACTIVE env_var
-
-
-
feat(config): get_golem_* now tries to guess if not found in yaml
+ get_golem_wd tries golem::pkg_path + get_golem_name tries pkg_name + get_golem_version tries pkg_version
-
-
-
-
-
-
-
-
-
Merge branch 'issue-709-reborn' of https://github.com/ThinkR-open/golem…
… into issue-709-reborn
-
-
-
doc: funs documented & param names
- Unified param name for pkg/path - set_golem_wd() is now correctly documented
Commits on Aug 11, 2022
-
fix: issue with pkg_path when not in project
Move to here::here() for now
-
feat: create add_partial_html_template() (ThinkR-open#894)
Co-authored-by: Colin Fay <[email protected]> Co-authored-by: vincent guyader <[email protected]>
3 people authoredAug 11, 2022 -
-
Commits on Aug 16, 2022
Commits on Aug 17, 2022
Commits on Aug 18, 2022
-
fix(config): unifying config manipulation
All config manipulation now go through amend_golem_config. This allows to be sure that the !expr are not lost Close ThinkR-open#709
-
-
-
doc: Added min version for rlang
To use rlang::check_install(version = ), we need at least {rlang) 1.0.0 Close ThinkR-open#905 -
Commits on Aug 19, 2022
-
fix: add_ fns can no longer take length(name) > 1 (ThinkR-open#910)
Functions that add or use files can no longer take an argument name of length() > 1 close ThinkR-open#781
-
-
Commits on Oct 12, 2022
-
-
-
We needed to release a version for golem to stay on CRAN but a real release was not ready, hence a small 0.3.4
-
Commits on Oct 13, 2022
Commits on Oct 14, 2022
Commits on Oct 27, 2022
-
-
-
We needed to release a version for golem to stay on CRAN but a real release was not ready, hence a small 0.3.4
-
-
-
Merge branch 'dev' of https://github.com/ThinkR-open/golem into dev # Conflicts: # DESCRIPTION # NEWS.md # R/add_dockerfiles.R # R/modules_fn.R # man/dockerfiles.Rd # tests/testthat/test-zzzzzzzzzz.R
-
-
-
Commits on Oct 28, 2022
Commits on Nov 7, 2022
-
feat: Create html template for maintenance mode
Issue Add a maintenance mode ? ThinkR-open#820
-
-
-
-
Commits on Dec 7, 2022
-
* fix ThinkR-open#944 force lowercase for package name in Dockerfile * check_is_installed is back again instead of fs_file_copy for dockerfile creation * set version to 0.3.5.9001
-
Fix 944 and correct CI (ThinkR-open#947)
* fix ThinkR-open#944 force lowercase for package name in Dockerfile * check_is_installed is back again instead of fs_file_copy for dockerfile creation * set version to 0.3.5.9001
-
fix dev branch (ThinkR-open#948)
* fix allow pkgload no to be installed * fix document_and_reload rd * chore update NEWS and bump version * fix force repos in test to avoid "trying to use CRAN without setting a mirror"
Commits on Dec 8, 2022
Commits on Dec 9, 2022
-
draft : 950 without cli (ThinkR-open#951)
* remove cli and crayon from hard deps
-
update maintenance mode (ThinkR-open#952)
* fix pkgdown * explain maintenance mode
Commits on Dec 10, 2022
-
feat: remove rstudioapi hard dep (ThinkR-open#955)
* feat: remove rstudioapi hard dep * remove rstudioapi from NAMESPACE Co-authored-by: Colin Fay <[email protected]>
Commits on Dec 12, 2022
-
fix ThinkR-open#956 improve get_golem_options doc (ThinkR-open#957)
* fix ThinkR-open#956 improve get_golem_options doc * fix doc * add news
-
fix 958 save all before run_dev.R (ThinkR-open#959)
* fix 958 save all before run_dev.R * add news
Commits on Dec 14, 2022
Commits on Dec 23, 2022
-
-
-
-
-
Merge pull request ThinkR-open#967 from ThinkR-open/issue-923-yogat3c…
…h-for-cherry-pick
-
-
-
Commits on Jan 20, 2023
-
Update add_dockerfiles_renv.R (ThinkR-open#976)
fix : allow using `add_dockerfile_with_renv without` attachment and/or detect if package is missing
Commits on Jan 28, 2023
-
fix: allow to build readme in 01_start
tags: fix, doc Why? - I need to be able to commit right after running the complete "dev/01_dev.R" How? - To commit, I need the Readme.md file to be created, after I created the Readme.Rmd file. - devtools::build_readme() allows to install the package temporarily with its last version to be able to knit the Readme.Rmd in the last good conditions
Commits on Jan 29, 2023
-
Merge pull request ThinkR-open#979 from ThinkR-open/dev-build-readme
fix: allow to build readme in 01_start
-
draft : Temp (ThinkR-open#977)
* Pass `require_suggets` to `attachment_create_renv_for_prod` * feat : force check_if_suggests_is_installed = FALSE in renv creation * feat : add test to check suggested package are not in renv.lock * fix : explictly use library(appname) before launching an app un Dockerfile issue : ThinkR-open#978 * fix : update add_dockerfile_with_renv * fix : check_installed is more cleaver * fix : add {renv} to dev_deps (its already in {dockerfiler}'s deps, but it seems safer to do this. --------- Co-authored-by: Stephen Holsenbeck <[email protected]>
-
Commits on Feb 22, 2023
Commits on Mar 6, 2023
Commits on Mar 10, 2023
-
-
-
* fix ThinkR-open#944 force lowercase for package name in Dockerfile * check_is_installed is back again instead of fs_file_copy for dockerfile creation * set version to 0.3.5.9001
-
-
-
-
Commits on Mar 15, 2023
-
feat: is_golem tries to guess if current folder is a golem based app
This can be used to check before running a module/project template close issue ThinkR-open#836
-
-
-
Commits on Mar 17, 2023
Commits on Mar 29, 2023
-
Add function body upon call to add_fct
- fix 1004 adding bare skeleton function body - function name taken from 'name' arg to add_fct
-
-
Commits on Mar 31, 2023
Commits on Apr 4, 2023
-
Add -it flag when run docker so ^C still works
Add -it flag when run docker so ^C still works
-
-
-
- check if README.Rmd exists; throw error if arg overwrite = FALSE, but overwrite if TRUE - uses a template from a function that returns an appropriate character - sets devtools::check chunk with option error=TRUE at the moment to ease testing this feature Possible To-Dos: - use smarter template e.g. from specific template-file.Rmd a-la usethis+whisker - add use_readme_md() that adds the correspodining .md file
-
-
feat: implement use_readme_rmd
- Rework of @ilyaZar first implem Issue ThinkR-open#1011
-
-
-
-
-
-
docs: improve explanation comments in 01_start
- add more precise description for each argument in fill_desc() - change some capital letters to lower case in fill_desc() comments
-
-
-
-
-
-
fix: improve code coverage for R/golem_utils_ui.R
- fix missing tests for make_action_button - possible bugfix for make_action_button - check with grepl instead of grep to avoid numeric(0) in if-statement which would make the corresponding test fail for button_6: class attribute present but not equal to "action-button" gives an error -
fix: make code coverage of R/golem_utils_ui.R 100%
- fix missing test for undisplay
-
fix: make code coverage of R/golem_utils_server.R 100%
- add missing tests for rv and rvtl
-
-
Commits on May 16, 2023
-
1. add a double check to look for modules with names starting with "mod_mod_xxx" (see R/add_r_files.R) 2. add syntax check for module names to add_module(): explicitly ask the user if s/he wants to name her module "mod_xxx" or "mod_mod_xxx"
-
-
-
fix: set_golem_name updates name for ./tests content
- save old golem name in tmp-variable and use helper-func inside set_golem_name() to overwrite tests/testthat.R - helper-func screens for old_name instances and replaces them with new_name Refs: ThinkR-open#805
-
fix: set_golem_name updates name for ./vignettes content
- save <old_name> in tmp-variable and use helper-func inside set_golem_name() to change file name from "vignettes/<old_name>.R" to "vignettes/<new_name>.R" - helper-func screens for old_name instances inside <vignettes/<old_name>.R> and replaces them with new_name, then saves output to "vignettes/<new_name>.R" Refs: ThinkR-open#805
-
- adding a message to the user to check for other places for the name - passing the path to sub functions
-
-
-
-
Commits on May 17, 2023
-
fix: allow golem to use person vector
- remove 'author_XXX' args and replace with 'authors' - make 'authors' arg default to class 'person' - use class check on 'authors', throw error if it fails - use desc$set_authors This mostly draws from the ideas of @jmeyer2482 and @ColinFay: Co-authored-by: Colin Fay <[email protected]> Co-authored-by: jmeyer2482 <[email protected]>
3 people committedMay 17, 2023 -
-
- update vignette/a_start.Rmd with new fill_desc() interface - delete some redundant whitespaces in same file
-
refactor: update tests for fill_desc()
- changes since values of authors are of type person() which requires parsing the entries -
refactor: update inst/mantests/build.R
- adjust interace of fill_desc() so build.R runs smoothly
-
-
-
-
Revert "Add -it flag when run docker so ^C still works"
This reverts commit ac237d5.
-
Commits on May 24, 2023
-
refactor: merge commit from branch fix-change-config-yml-loc
Merge branch 'fix-change-config-yml-loc' of https://github.com/ThinkR-open/golem into fix-change-config-yml-loc # Conflicts: # R/config.R # tests/testthat/test-config.R
-
fix: add user supplied path to config for guess_where_config()
- add helper try_user_config_location() that searchers for the new config location which is to be set inside R/app_config.R - update guess_where_config() with a final guess using this helper
-