Bmoric/extract logs api #18621
Merged
Bmoric/extract logs api #18621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vert-server-to-micronaut
…tehq/airbyte into bmoric/extract-connection-api
…tehq/airbyte into bmoric/extract-connection-api
…ract-connection-api
…ract-connection-api
…airbyte into bmoric/extract-db-migration-api
…ract-db-migration-api
…ract-db-migration-api
…q/airbyte into bmoric/extract-destination-definition-api
…m:airbytehq/airbyte into bmoric/extract-destination-definition-specification-api
github-actions
bot
added
area/platform
| import lombok.AllArgsConstructor; | ||
|
|
||
| @AllArgsConstructor | ||
| public class LogsApiController implements LogsApi { |
There was a problem hiding this comment.
Is this missing a path?
There was a problem hiding this comment.
Yes and no. Adding the path is not needed because it is inherited from the interface but I prefer to add it in order to avoid to have to look at the interface know the path when you are debugging. I have added it now.
|
@benmoriceau Looks like the PR contains PMD violations. |
…e into bmoric/extract-logs-api
gosusnp
approved these changes
Nov 2, 2022
|
Build passed I'll merge without waiting for the acceptance test |
letiescanciano
added a commit
that referenced
this pull request
Nov 3, 2022
* master: (38 commits) New Source: Gridly (#18342) 🎉 New Source: Alpha Vantage (#18320) ci_integration_test.sh: cut GITHUB_STEP_SUMMARY (#18895) 🎉 New Source: Datadog [python cdk] (#18150) Hide Reject all button in consent dialog (#18596) feat: add doc url to track event (#18690) fix: install java in oss catalog deploy action (#18887) [CI] Speed up check_images_exist (#18873) Extract open API (#18879) Remove unused interfaces (#18880) add action for deploying oss connector catalog to GCS (#18633) feat: generate full connector catalog json (#18562) Add unsupported_protocol_version column to Connection (#18876) Extract OAuth API (#18818) update images to have non-transparent background (#18874) DiscoverSchema endpoints calculates diff and breaking change (#18571) Validate protocol version on connector update (#18639) Bmoric/extract notification api (#18812) Show version and changelog status for affected connectors (#18845) Bmoric/extract logs api (#18621) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In order to be prepared for a smoother migration to Micronaut for the server, an effort must be made to break the ConfigurationApi into multiple classes. This PR is the first one of a series of PR to come.
How
Extract the LogsApi into its own class
Recommended reading order
No specific order