-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Speed up check_images_exist #18873
[CI] Speed up check_images_exist #18873
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic @perangel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Now I'm curious though about why we were pulling platform images to begin with.
@davinchia do you have any extra context around why we were pulling platform images to verify they exist instead of just checking the API response (which is what we already do for connector images anyway)?
ran locally. output for others √ airbyte $ ./tools/bin/check_images_exist.sh all
./tools/bin/check_images_exist.sh:20: set +o xtrace
checking images for: all
Checking platform images exist...
airbyte/init: 0.40.18
URL: https://hub.docker.com/v2/repositories/airbyte/init/tags/0.40.18
STATUS: found
airbyte/bootloader: 0.40.18
URL: https://hub.docker.com/v2/repositories/airbyte/bootloader/tags/0.40.18
STATUS: found
airbyte/db: 0.40.18
URL: https://hub.docker.com/v2/repositories/airbyte/db/tags/0.40.18
STATUS: found
airbyte/worker: 0.40.18
URL: https://hub.docker.com/v2/repositories/airbyte/worker/tags/0.40.18
STATUS: found
airbyte/server: 0.40.18
URL: https://hub.docker.com/v2/repositories/airbyte/server/tags/0.40.18
<more lines here>
airbyte/source-firebolt: 0.1.0
URL: https://hub.docker.com/v2/repositories/airbyte/source-firebolt/tags/0.1.0
STATUS: found
airbyte/source-elasticsearch: 0.1.0
URL: https://hub.docker.com/v2/repositories/airbyte/source-elasticsearch/tags/0.1.0
STATUS: found
airbyte/source-waiteraid: 0.1.0
URL: https://hub.docker.com/v2/repositories/airbyte/source-waiteraid/tags/0.1.0
STATUS: found
airbyte/source-yandex-metrica: 0.1.0
URL: https://hub.docker.com/v2/repositories/airbyte/source-yandex-metrica/tags/0.1.0
STATUS: found
airbyte/source-zoom: 0.1.0
URL: https://hub.docker.com/v2/repositories/airbyte/source-zoom/tags/0.1.0
STATUS: found
Success! All connector images exist!
Image check complete. |
* master: (38 commits) New Source: Gridly (#18342) 🎉 New Source: Alpha Vantage (#18320) ci_integration_test.sh: cut GITHUB_STEP_SUMMARY (#18895) 🎉 New Source: Datadog [python cdk] (#18150) Hide Reject all button in consent dialog (#18596) feat: add doc url to track event (#18690) fix: install java in oss catalog deploy action (#18887) [CI] Speed up check_images_exist (#18873) Extract open API (#18879) Remove unused interfaces (#18880) add action for deploying oss connector catalog to GCS (#18633) feat: generate full connector catalog json (#18562) Add unsupported_protocol_version column to Connection (#18876) Extract OAuth API (#18818) update images to have non-transparent background (#18874) DiscoverSchema endpoints calculates diff and breaking change (#18571) Validate protocol version on connector update (#18639) Bmoric/extract notification api (#18812) Show version and changelog status for affected connectors (#18845) Bmoric/extract logs api (#18621) ...
What
Small performance optimization for how we check for the existence of images in
tools/bin/check_images_exist.sh
.How
docker compose pull
to verify if an image referenced in a docker compose file existsRecommended reading order
x.java
y.python
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.