Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🔧 Add doc url to track event #18690

Merged
merged 4 commits into from
Nov 3, 2022
Merged

🪟 🔧 Add doc url to track event #18690

merged 4 commits into from
Nov 3, 2022

Conversation

arnaudjnn
Copy link
Contributor

@arnaudjnn arnaudjnn commented Oct 31, 2022

What

We need to have the connector url in Customer.io events to run this experiment.

How

Add the docUrl inside the Segment track event.

🚨 User Impact 🚨

No user impact

@arnaudjnn arnaudjnn requested a review from a team as a code owner October 31, 2022 14:06
@CLAassistant
Copy link

CLAassistant commented Oct 31, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Oct 31, 2022
@timroes
Copy link
Collaborator

timroes commented Oct 31, 2022

@arnaudjnn You'll still need to sign the CLA before this can be merged.

Please also have a look at our (internal) Notion page running you through how we write PR titles, as well as please cleanup the PR description to strip unnecessary details from it.

@arnaudjnn arnaudjnn changed the title feat: add doc url to track event 🔧 Add doc url to track event Oct 31, 2022
@arnaudjnn
Copy link
Contributor Author

@timroes

I updated the title + desc and signed the CLA.

@timroes timroes changed the title 🔧 Add doc url to track event 🪟 🔧 Add doc url to track event Oct 31, 2022
Copy link
Collaborator

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, have not tested locally

Copy link
Contributor

@letiescanciano letiescanciano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, Segment event includes the info correctly.
Haven't checked customer.io flow yet
Screen Shot 2022-10-31 at 5 52 21 PM

@arnaudjnn arnaudjnn merged commit 3255c07 into master Nov 3, 2022
@arnaudjnn arnaudjnn deleted the aj/track-doc-url branch November 3, 2022 07:46
letiescanciano added a commit that referenced this pull request Nov 3, 2022
* master: (38 commits)
  New Source: Gridly (#18342)
  🎉 New Source: Alpha Vantage (#18320)
  ci_integration_test.sh: cut GITHUB_STEP_SUMMARY (#18895)
  🎉 New Source: Datadog [python cdk] (#18150)
  Hide Reject all button in consent dialog (#18596)
  feat: add doc url to track event (#18690)
  fix: install java in oss catalog deploy action (#18887)
  [CI] Speed up check_images_exist (#18873)
  Extract open API (#18879)
  Remove unused interfaces (#18880)
  add action for deploying oss connector catalog to GCS (#18633)
  feat: generate full connector catalog json (#18562)
  Add unsupported_protocol_version column to Connection (#18876)
  Extract OAuth API (#18818)
  update images to have non-transparent background (#18874)
  DiscoverSchema endpoints calculates diff and breaking change (#18571)
  Validate protocol version on connector update (#18639)
  Bmoric/extract notification api (#18812)
  Show version and changelog status for affected connectors (#18845)
  Bmoric/extract logs api (#18621)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants