Merge from grantami-bomanalytics-private #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FEAT: update 24.1.213
…edits Sustainability example changes
Docs: add sustainability example
Make sure this class isn't collected by pytest
Rename external_id on part to external_identity
Rename with_legislations to with_legislation_ids
Fix: handle lack of material reference
Doc: address outstanding docs improvements
Optional changes from documentation review
Use public bomanalytics-openapi
|
Updated all relevant secrets, CI seems to be passing. |
|
It looks reasonable from a quick spot check on some files. |
|
Wait to merge this until we have released a new version of bomanalytics-openapi |
|
Updated to use the v2.0.0 of bomanalytics-openapi See #388 for some codacy fixes. The others are either not real errors or more difficult to fix at this point |
ludovicsteinbach
approved these changes
Jan 15, 2024
* Codacy fixes * Add dummy variable
* Fix broken reference * Update Product Docs URL
|
Merging as-is, the codacy issues are acceptable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporate all development from private fork
Obviously there's a huge number of commits here, that represent the complete development of the sustainability portion of this package. I have gone through the workflow files and cleaned out any private-specific additions though, so hopefully CI will complete.