Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create visualizer for system_error_monitor #673

Open
3 of 5 tasks
h-ohta opened this issue Apr 12, 2022 · 3 comments
Open
3 of 5 tasks

Create visualizer for system_error_monitor #673

h-ohta opened this issue Apr 12, 2022 · 3 comments
Assignees
Labels
component:tools Utility and debugging software. (auto-assigned) status:help-wanted Assistance or contributors needed. status:stale Inactive or outdated issues. (auto-assigned) type:new-feature New functionalities or additions, feature requests.

Comments

@h-ohta
Copy link
Contributor

h-ohta commented Apr 12, 2022

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

The diagnostics_aggregator is visualized in rqt_robot_monitor, and DiagnosticsArray messages are also visualized in rqt_runtime_monitor.

However, we don't have any visualizer for system_error_monitor now.
For example, when we fall into emergency, we have to echo some topics from system_error_monitor with terminal and analyse them to resolve.

Purpose

The purpose of this task is to create some visualization ways to check system_error_monitor status with GUI more easily.
I believe this function can able to make our developers to resolve the problem like emergency more quickly.

Possible approaches

Various approaches are considered

  • create rqt plugin same as rqt_robot_monitor
  • create rviz plugin
  • create other GUI approaches

Definition of done

  • created some visualization ways
  • We can check the status and the problem by using them
@kenji-miyake
Copy link
Contributor

@h-ohta Have you tried ros2 run rqt_runtime_monitor rqt_runtime_monitor --ros-args -r /diagnostics:=/diagnostics_err?

@h-ohta
Copy link
Contributor Author

h-ohta commented Apr 12, 2022

Yes, I tried it.
I confirmed when a diag are staled, the [Single Point Fault] flag is added to it.
However, I can't confirm emergency and emergency_holding status from it.

13304490790 pushed a commit to 13304490790/autoware.universe that referenced this issue Apr 12, 2022
* release v0.4.0

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <[email protected]>

* add sample ros2 packages

Signed-off-by: mitsudome-r <[email protected]>

* remove ROS1 packages

Signed-off-by: mitsudome-r <[email protected]>

* Revert "remove ROS1 packages temporarily"

This reverts commit bcc60bdc82842e2ea4d1e844b4442fa613d80fdf.

Signed-off-by: mitsudome-r <[email protected]>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <[email protected]>

* Port shift decider to ros2 (autowarefoundation#7)

* Update package.xml and CMakeLists.txt to ros2

Code doesn't compile yet

* Code compiles

* Update launch file

* Add better timer

clang-format shift_decider

* Rename h files to hpp (autowarefoundation#142)

* Change includes

* Rename files

* Adjustments to make things compile

* Other packages

* Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143)

* Use quotes for includes where appropriate (autowarefoundation#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151)

* Run uncrustify on the entire Pilot.Auto codebase

* Exclude open PRs

* Added linters to shift_decider (autowarefoundation#167)

* Added linters to shift_decider

* Fix dependencies

* Use ament_cmake_cppcheck and ament_cmake_cpplint

* Fix linting errors

* add use_sim-time option (autowarefoundation#454)

* Unify Apache-2.0 license name (autowarefoundation#1242)

* Make control modules components (autowarefoundation#1262)

Signed-off-by: wep21 <[email protected]>

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <[email protected]>

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <[email protected]>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <[email protected]>

* Apply Black

Signed-off-by: Kenji Miyake <[email protected]>

* Apply clang-format

Signed-off-by: Kenji Miyake <[email protected]>

* Fix build errors

Signed-off-by: Kenji Miyake <[email protected]>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <[email protected]>

* Apply clang-format

Signed-off-by: Kenji Miyake <[email protected]>

* Fix build errors

Signed-off-by: Kenji Miyake <[email protected]>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <[email protected]>

* port shift decider (autowarefoundation#485)

* port shift decider

* apply clang format

* delete colcon ignore

* change to ackermann control command

* remove VehicleStateReport/VehicleStateCommand/VehicleControlCommand (autowarefoundation#549)

* fix autoware_error_monitor

* fix state monitor

* fix emergency handler(vehicle_state_report)

* fix emergency Handler(vehicle_state_command)

* fix shift_decider

* fix emergency_handler(vehicle_control_command)

* fix topic name

* fix readme

* Update system/autoware_state_monitor/Readme.md

Co-authored-by: taikitanaka3 <[email protected]>

* fix format

* Update system/autoware_state_monitor/launch/autoware_state_monitor.launch.xml

Co-authored-by: taikitanaka3 <[email protected]>

* fix typo

Co-authored-by: taikitanaka3 <[email protected]>

* [shift decider] add README.md (autowarefoundation#577)

* add readme to shift decider

* better expression

Co-authored-by: tkimura4 <[email protected]>

Co-authored-by: taikitanaka3 <[email protected]>
Co-authored-by: tkimura4 <[email protected]>

* Fix topic name (autowarefoundation#673)

Co-authored-by: mitsudome-r <[email protected]>
Co-authored-by: Frederik Beaujean <[email protected]>
Co-authored-by: Nikolai Morin <[email protected]>
Co-authored-by: Esteve Fernandez <[email protected]>
Co-authored-by: tkimura4 <[email protected]>
Co-authored-by: Kazuki Miyahara <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: Keisuke Shima <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Sugatyon <[email protected]>
Co-authored-by: taikitanaka3 <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
13304490790 pushed a commit to 13304490790/autoware.universe that referenced this issue Apr 12, 2022
* release v0.4.0

* add dynamic_reconfigure to obstacle avoidance planner (autowarefoundation#673)

* fix apply dynamic param (autowarefoundation#704)

* add warning logging to foa.data.is_is_avoidance_possible (autowarefoundation#725)

* Feature/improve obstacle avoidance (autowarefoundation#731)

* add license terms (autowarefoundation#941)

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <[email protected]>

* Revert "remove ROS1 packages temporarily"

This reverts commit 10813fa0e7b67c9ad6c7d4df6aeee0931c866b41.

Signed-off-by: mitsudome-r <[email protected]>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <[email protected]>

* Rename launch files to launch.xml (autowarefoundation#28)

* Port of obstacle avoidance planner to ROS2 (autowarefoundation#83)

* Port to ROS2

Signed-off-by: Servando German Serrano <[email protected]>

* Removed ros/console include

Signed-off-by: Servando German Serrano <[email protected]>

* Added THROTTLE

Signed-off-by: Servando German Serrano <[email protected]>

* Changed numbers to floats

Signed-off-by: Servando German Serrano <[email protected]>

* Removed <double> from params

Signed-off-by: Servando German Serrano <[email protected]>

* Added new msg

Signed-off-by: Servando German Serrano <[email protected]>

* Use new msg

Signed-off-by: Servando German Serrano <[email protected]>

* Replaced dynamic reconfigure

Signed-off-by: Servando German Serrano <[email protected]>

* Added EnableAvoidance.msg

Signed-off-by: Servando German Serrano <[email protected]>

* Fixed parameter mismatch

Signed-off-by: Servando German Serrano <[email protected]>

* Fix launch files (autowarefoundation#122)

* [surround_obstacle_checker] add parameter and arguments to launch file

Signed-off-by: mitsudome-r <[email protected]>

* [obstacle_stop_planner] modify launch file to remap trajectory from argument

Signed-off-by: mitsudome-r <[email protected]>

* [obstacle_avoidance_planner] modify launch file to remap topics from arguments

Signed-off-by: mitsudome-r <[email protected]>

* [motion_velocity_optimizer] modify launch file to enable remapping from argument

Signed-off-by: mitsudome-r <[email protected]>

* Convert calls of Duration to Duration::from_seconds where appropriate (autowarefoundation#131)

* Rename h files to hpp (autowarefoundation#142)

* Change includes

* Rename files

* Adjustments to make things compile

* Other packages

* Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143)

* Use quotes for includes where appropriate (autowarefoundation#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151)

* Run uncrustify on the entire Pilot.Auto codebase

* Exclude open PRs

* [lane_change_planner] [obstacle_avoidance_planner] fix clock type (autowarefoundation#183)

Signed-off-by: mitsudome-r <[email protected]>

* Add linters to obstacle_avoidance_planner (autowarefoundation#158)

* Added linters to obstacle_avoidance_planner

* Fix header issues

* Fix linting issues

* Fix more linting issues

* Fix even more linting issues

* Final linting fixes

* Fix dependencies

* Use ament_cmake_cppcheck and ament_cmake_cpplint

* [obstacle_avoidance_planner] add missing return values (autowarefoundation#214)

Signed-off-by: mitsudome-r <[email protected]>

* Obstacle avoidance planner 0.8 (autowarefoundation#308)

* fix rosparam typo

Signed-off-by: Kosuke Murakami <[email protected]>

* empty check before access

Signed-off-by: Kosuke Murakami <[email protected]>

* modify way to fix the points

Signed-off-by: Kosuke Murakami <[email protected]>

* apply format

Signed-off-by: Kosuke Murakami <[email protected]>

* add baselink2front dist for virutual_wall

Signed-off-by: Kosuke Murakami <[email protected]>

* add avoiding object type

Signed-off-by: Kosuke Murakami <[email protected]>

* add exception handling for avoiding object

Signed-off-by: Kosuke Murakami <[email protected]>

* apply format

Signed-off-by: Kosuke Murakami <[email protected]>

* add vehicle_info dependency

Signed-off-by: Kosuke Murakami <[email protected]>

* modify to pass lint

Signed-off-by: Kosuke Murakami <[email protected]>

* fix lint

Signed-off-by: Kosuke Murakami <[email protected]>

* add vehicle_info_param in launch

Signed-off-by: Kosuke Murakami <[email protected]>

* modify nested pram declaration

Signed-off-by: Kosuke Murakami <[email protected]>

* apply ament-uncrastify

Signed-off-by: Kosuke Murakami <[email protected]>

* fix boost_none handling (autowarefoundation#349)

* fix boost_none handling

Signed-off-by: Kosuke Murakami <[email protected]>

* add another one

Signed-off-by: Kosuke Murakami <[email protected]>

* add another one

Signed-off-by: Kosuke Murakami <[email protected]>

* add another one

Signed-off-by: Kosuke Murakami <[email protected]>

* Rename ROS-related .yaml to .param.yaml (autowarefoundation#352)

* Rename ROS-related .yaml to .param.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* Remove prefix 'default_' of yaml files

Signed-off-by: Kenji Miyake <[email protected]>

* Rename vehicle_info.yaml to vehicle_info.param.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* Rename diagnostic_aggregator's param files

Signed-off-by: Kenji Miyake <[email protected]>

* Fix overlooked parameters

Signed-off-by: Kenji Miyake <[email protected]>

* rename vehicle_info_param to vehicle_param_file (autowarefoundation#353)

Signed-off-by: Kosuke Murakami <[email protected]>

* Ros2 fix topic name part1 (autowarefoundation#408)

* Fix topic name of lane_departure_checker debug

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of mpc_follower debug

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of velocity_controller debug

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of motion_velocity_optimizer debug

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of lane_change_planner debug

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of behavior_velocity_planner debug

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of obstacle_avoidance_planner debug

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of behavior_velocity_planner

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of motion_velocity_optimizer

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of lane_departure_checker

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of mpc_follower

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of behavior_velocity_planner

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of velocity_controller

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of lane_change_planner

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of obstacle_avoidance_planner

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of obstacle_stop_planner

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of costmap_generator

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of freespace_planner

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of surround_obstacle_checker

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of costmap_generator

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of emergency_handler

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix lint errors

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix typo

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix typo in planning module (autowarefoundation#432)

* Fix typo in planning module

* Fix remaining errors

Signed-off-by: Kenji Miyake <[email protected]>

* Apply cpplint and uncrustify.

Co-authored-by: Kenji Miyake <[email protected]>

* fix duration (autowarefoundation#445)

* fix duration

Signed-off-by: Kosuke Murakami <[email protected]>

* change to from_seconds

Signed-off-by: Kosuke Murakami <[email protected]>

* fix other duration

Signed-off-by: Kosuke Murakami <[email protected]>

* replace -1 with 0

Signed-off-by: Kosuke Murakami <[email protected]>

* apply ament_lint_common

Signed-off-by: Kosuke Murakami <[email protected]>

* uncrustify

Signed-off-by: Kosuke Murakami <[email protected]>

* add space

Signed-off-by: Kosuke Murakami <[email protected]>

* add another space

Signed-off-by: Kosuke Murakami <[email protected]>

* update log (autowarefoundation#456)

Signed-off-by: Kosuke Murakami <[email protected]>

* fix bug (autowarefoundation#457)

* add use_sim-time option (autowarefoundation#454)

* Format launch files (autowarefoundation#1219)

Signed-off-by: Kenji Miyake <[email protected]>

* Fix rolling build errors (autowarefoundation#1225)

* Add missing include files

Signed-off-by: Kenji Miyake <[email protected]>

* Replace rclcpp::Duration

Signed-off-by: Kenji Miyake <[email protected]>

* Use reference for exceptions

Signed-off-by: Kenji Miyake <[email protected]>

* Use from_seconds

Signed-off-by: Kenji Miyake <[email protected]>

* Sync public repo (autowarefoundation#1228)

* [simple_planning_simulator] add readme (autowarefoundation#424)

* add readme of simple_planning_simulator

Signed-off-by: Takamasa Horibe <[email protected]>

* Update simulator/simple_planning_simulator/README.md

* set transit_margin_time to intersect. planner (autowarefoundation#460)

* Fix pose2twist (autowarefoundation#462)

Signed-off-by: Takagi, Isamu <[email protected]>

* Ros2 vehicle info param server (autowarefoundation#447)

* add vehicle_info_param_server

* update vehicle info

* apply format

* fix bug

* skip unnecessary search

* delete vehicle param file

* fix bug

* Ros2 fix topic name part2 (autowarefoundation#425)

* Fix topic name of traffic_light_classifier

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of traffic_light_visualization

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of traffic_light_ssd_fine_detector

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of traffic_light_map_based_detector

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix lint traffic_light_recognition

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix lint traffic_light_ssd_fine_detector

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix lint traffic_light_classifier

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix lint traffic_light_classifier

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix lint traffic_light_ssd_fine_detector

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix issues in hdd_reader (autowarefoundation#466)

* Fix some issues detected by Coverity Scan and Clang-Tidy

* Update launch command

* Add more `close(new_sock)`

* Simplify the definitions of struct

* fix: re-construct laneletMapLayer for reindex RTree (autowarefoundation#463)

* Rviz overlay render fix (autowarefoundation#461)

* Moved painiting in SteeringAngle plugin to update()

Signed-off-by: Adam Dabrowski <[email protected]>

* super class now back to MFD

Signed-off-by: Adam Dabrowski <[email protected]>

* uncrustified

Signed-off-by: Adam Dabrowski <[email protected]>

* acquire data in mutex

Signed-off-by: Adam Dabrowski <[email protected]>

* back to RTD as superclass

Signed-off-by: Adam Dabrowski <[email protected]>

* Rviz overlay render in update (autowarefoundation#465)

* Moved painiting in SteeringAngle plugin to update()

Signed-off-by: Adam Dabrowski <[email protected]>

* super class now back to MFD

Signed-off-by: Adam Dabrowski <[email protected]>

* uncrustified

Signed-off-by: Adam Dabrowski <[email protected]>

* acquire data in mutex

Signed-off-by: Adam Dabrowski <[email protected]>

* removed unnecessary includes and some dead code

Signed-off-by: Adam Dabrowski <[email protected]>

* Adepted remaining vehicle plugin classes to render-in-update concept. Returned to MFD superclass

Signed-off-by: Adam Dabrowski <[email protected]>

* restored RTD superclass

Signed-off-by: Adam Dabrowski <[email protected]>

Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: tkimura4 <[email protected]>
Co-authored-by: Takagi, Isamu <[email protected]>
Co-authored-by: Kazuki Miyahara <[email protected]>
Co-authored-by: Makoto Tokunaga <[email protected]>
Co-authored-by: Adam Dąbrowski <[email protected]>

* Unify Apache-2.0 license name (autowarefoundation#1242)

* Make planning modules components (autowarefoundation#1263)

Signed-off-by: wep21 <[email protected]>

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <[email protected]>

* Porting small fix (autowarefoundation#1288)

* Delete unused code (autowarefoundation#1183)

* Fix control topic name of closest_velocity_checker.py (autowarefoundation#1174)

Signed-off-by: Kenji Miyake <[email protected]>

* Add comments for livox tag (autowarefoundation#1188)

Signed-off-by: Kenji Miyake <[email protected]>

* Clear return value (autowarefoundation#1193)

* Change tracker model of unknown object (autowarefoundation#1204)

* treat polygon points as relative (autowarefoundation#1205)

Signed-off-by: Kosuke Murakami <[email protected]>

* hotfix: reference velocity in consideration of vehicle gear (autowarefoundation#1213)

* fix reference velocity for vehicle gear

* add initialization

* revert

* add comment

* change max area param (autowarefoundation#1218)

* Fix an identical code for different branches (autowarefoundation#1230)

* Update livox_tag_filter.launch.xml

* Fixup

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: shin <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
Co-authored-by: Yukihiro Saito <[email protected]>
Co-authored-by: Kosuke Murakami <[email protected]>
Co-authored-by: Hiroki OTA <[email protected]>
Co-authored-by: tkimura4 <[email protected]>
Co-authored-by: Kazuki Miyahara <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>

* Refactor vehicle info util (autowarefoundation#1305)

* Update license

Signed-off-by: Kenji Miyake <[email protected]>

* Refactor vehicle_info_util

Signed-off-by: Kenji Miyake <[email protected]>

* Rename and split files

Signed-off-by: Kenji Miyake <[email protected]>

* Fix interfaces

Signed-off-by: Kenji Miyake <[email protected]>

* Fix bug and add error handling

Signed-off-by: Kenji Miyake <[email protected]>

* Add "// namespace"

Signed-off-by: Kenji Miyake <[email protected]>

* Add missing include

Signed-off-by: Kenji Miyake <[email protected]>

* Fix lint errors (autowarefoundation#1378)

* Fix lint errors

Signed-off-by: Kenji Miyake <[email protected]>

* Fix variable names

Signed-off-by: Kenji Miyake <[email protected]>

* Disable debug output of obstacle_avoidance_planner by default (autowarefoundation#1391)

* Disable debug output of obstacle_avoidance_planner by default

Signed-off-by: Kenji Miyake <[email protected]>

* Fix typo

Signed-off-by: Kenji Miyake <[email protected]>

* suppress warnings for obstacle avoidance planner (autowarefoundation#1764)

* add Werror

* fix Duration

* fix debug.cpp

* fix node.cpp

* fix util.cpp

* fix for loop for mpt_optimizer.cpp

* fix unused for mpt_optimizer.cpp

* fix process_cv.cpp

* fix sign compare for eb_path_optimizer.cpp

* fix unused for eb_path_optimizer.cpp

* fix for cpplint

* fix for cpplint

* re fix debug.cpp

* fix typo

* fix typo

* re fix process_cv.cpp

* fix typo

* re fix util.cpp

* re re fix util.cpp

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <[email protected]>

* Fix mistake

Signed-off-by: Kenji Miyake <[email protected]>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <[email protected]>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: Hiroki OTA <[email protected]>

* Fix compiler warnings (autowarefoundation#1837)

* Fix -Wunused-private-field

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Wunused-variable

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Wformat-security

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Winvalid-constexpr

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Wdelete-non-abstract-non-virtual-dtor

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Wdelete-abstract-non-virtual-dtor

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Winconsistent-missing-override

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Wrange-loop-construct

Signed-off-by: Kenji Miyake <[email protected]>

* Fix "invalid application of 'sizeof' to an incomplete type"

Signed-off-by: Kenji Miyake <[email protected]>

* Ignore -Wgnu-anonymous-struct and -Wnested-anon-types

Signed-off-by: Kenji Miyake <[email protected]>

* Fix lint

Signed-off-by: Kenji Miyake <[email protected]>

* Ignore -Wno-deprecated-declarations in CUDA-related packages

Signed-off-by: Kenji Miyake <[email protected]>

* Fix mistake

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <[email protected]>

* Fix spellcheck fail for some packages (autowarefoundation#1842)

* fix transed -> transformed

* fix Urefex to Uref_ex

* fix spell

* Yrefex -> Yref_ex

* add space

* fix for spellcheck

* fix for lint

* fix feedbacked to feedback

* delete Yref_ex

* [obstacle avoidance planner] move doc from develop (autowarefoundation#1898)

* move doc from develop

* add figures

* update docs

* fix

* update doc

* use /approx

* use \sin \cos \tan

* use \arctan

* use \cos

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* remove spline_interpolation, and create interpolation package that ha… (autowarefoundation#2114)

* remove spline_interpolation and add interpolation package

* fix bugs and add simple test

* modify application for interpolation package

* add some tests and fix ci test

* add some tests

* add -Werror

* move functions to anonymous

* fix reviews

* fix typo

* fix review and lint

* add tests

* resolve TODOs

* add README.md

* Update common/math/interpolation/test/src/test_interpolation_utils.cpp

Co-authored-by: Kenji Miyake <[email protected]>

* Update common/math/interpolation/test/src/test_interpolation_utils.cpp

Co-authored-by: Kenji Miyake <[email protected]>

* Update common/math/interpolation/test/src/test_interpolation_utils.cpp

Co-authored-by: Kenji Miyake <[email protected]>

* fix README.md

* dealt with reviews

* update README.md

* update README.md

* Update common/math/interpolation/README.md

* fix some bugs

* fix typo

* update README.md

* Update common/math/interpolation/README.md

Co-authored-by: Kazuki Miyahara <[email protected]>

* fix test

* Update common/math/interpolation/README.md

Co-authored-by: Kazuki Miyahara <[email protected]>

* fix cdots

* fix README.md

* Update common/math/interpolation/README.md

Co-authored-by: Kazuki Miyahara <[email protected]>

Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Kazuki Miyahara <[email protected]>

* update doc (autowarefoundation#2164)

* update doc

* Update planning/scenario_planning/lane_driving/motion_planning/obstacle_avoidance_planner/obstacle_avoidance_planner-design.ja.md

* Update planning/scenario_planning/lane_driving/motion_planning/obstacle_avoidance_planner/obstacle_avoidance_planner-design.ja.md

* Update planning/scenario_planning/lane_driving/motion_planning/obstacle_avoidance_planner/obstacle_avoidance_planner-design.ja.md

Co-authored-by: Kazuki Miyahara <[email protected]>

* Update planning/scenario_planning/lane_driving/motion_planning/obstacle_avoidance_planner/obstacle_avoidance_planner-design.ja.md

Co-authored-by: Kazuki Miyahara <[email protected]>

* fix \min, \max

* Update planning/scenario_planning/lane_driving/motion_planning/obstacle_avoidance_planner/obstacle_avoidance_planner-design.ja.md

Co-authored-by: Kazuki Miyahara <[email protected]>

Co-authored-by: Kazuki Miyahara <[email protected]>

* update readme for how to debug (autowarefoundation#2253)

Signed-off-by: Takamasa Horibe <[email protected]>

* add explanation of drivable area in obstacle avoidance planner (autowarefoundation#2291)

* add explanation of drivable area in obstacle avoidance planner

* fix spell

* add explanations

* Sync develop/fix interpolation and speed up calculation (autowarefoundation#2290)

* debug slope calculation in behavior (autowarefoundation#1566) (autowarefoundation#1727)

* debug slope calculation in behavior (autowarefoundation#1566)

* update

* update

* revert change of autoware_utils

* define getPose in behavior_path_planner

* update

* update

* update

* update

* interpolate z in obstacle_avoidance_planner

* update velocity controller

* fix detection area and scene

* Update planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/src/utilities.cpp

Co-authored-by: tkimura4 <[email protected]>

* update comment in velocity controller

* remove debug print

* update

Co-authored-by: tkimura4 <[email protected]>
Signed-off-by: wep21 <[email protected]>

* Fix typo

Signed-off-by: wep21 <[email protected]>

* Fix variable names

Signed-off-by: Kenji Miyake <[email protected]>

* Fix uncrustify

Signed-off-by: Kenji Miyake <[email protected]>

* Fix mistake

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: Takayuki Murooka <[email protected]>
Co-authored-by: tkimura4 <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>

* add underscore to marker namespace (autowarefoundation#1785)

Co-authored-by: satoshi-ota <[email protected]>

* [obstacle_avoidance_planner] remove useless get nearest idx (autowarefoundation#1851)

* modify velocity insertion in obstacle_avoidance_planner

Signed-off-by: Takamasa Horibe <[email protected]>

* [obstacle_avoidance_planner] reduce calculation cost in relative/absolute transformation (autowarefoundation#1844)

* implement relative/absolute transformation without yaw but directly sin/cos of yaw

* rename: relative_p to absolute_p

* assigin point.z to rel/abs_z

* fix cpp-lint error

Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: Takayuki Murooka <[email protected]>
Co-authored-by: tkimura4 <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Satoshi OTA <[email protected]>
Co-authored-by: satoshi-ota <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>

* Feature/obstacle avoidance planner some improvements (autowarefoundation#1964)

* add some improvements

* fix typo

* Revert "Feature/obstacle avoidance planner some improvements (autowarefoundation#1964)" (autowarefoundation#2000)

This reverts commit 07795e57bf03cb2fbb95a8f82253d8757b4686e9.

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <[email protected]>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <[email protected]>

* Apply Black

Signed-off-by: Kenji Miyake <[email protected]>

* Apply clang-format

Signed-off-by: Kenji Miyake <[email protected]>

* Fix build errors

Signed-off-by: Kenji Miyake <[email protected]>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <[email protected]>

* Apply clang-format

Signed-off-by: Kenji Miyake <[email protected]>

* Fix build errors

Signed-off-by: Kenji Miyake <[email protected]>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <[email protected]>

* port obstacle avoidance planner (autowarefoundation#484)

* use_auto_msgs

* use predicted object

* use autoware_auto_perception_msgs

* complile succeeded

* use odom

* assign header to twist staped as well

* rename to readme.md

Co-authored-by: Takayuki Murooka <[email protected]>

* [apply_predicted_obj_type] adapt to autoware auto msgs (autowarefoundation#564)

* fix obj shape

* fix obj shape

* fix goal pose

* update README.md in obstacle avoidance planner (autowarefoundation#555)

* update README.md

* fix typo

* update README.md

* fix typo

* minor change

Co-authored-by: Takayuki Murooka <[email protected]>

* update iv_msgs -> auto_msgs in planning readme (autowarefoundation#576)

* update iv_msgs -> auto_msgs in planning readme

* minor change

* some fix

* some fix

Co-authored-by: Takayuki Murooka <[email protected]>

* Back port .auto control packages (autowarefoundation#571)

* Implement Lateral and Longitudinal Control Muxer

* [autowarefoundation#570] Porting wf_simulator

* [autowarefoundation#1189] Deactivate flaky test in 'trajectory_follower_nodes'

* [autowarefoundation#1189] Fix flacky test in 'trajectory_follower_nodes/latlon_muxer'

* [autowarefoundation#1057] Add osqp_interface package

* [autowarefoundation#1057] Add library code for MPC-based lateral control

* [autowarefoundation#1271] Use std::abs instead of abs

* [autowarefoundation#1057] Implement Lateral Controller for Cargo ODD

* [autowarefoundation#1246] Resolve "Test case names currently use snake_case but should be CamelCase"

* [autowarefoundation#1325] Deactivate flaky smoke test in 'trajectory_follower_nodes'

* [autowarefoundation#1058] Add library code of longitudinal controller

* Fix build error for trajectory follower

Signed-off-by: wep21 <[email protected]>

* Fix build error for trajectory follower nodes

Signed-off-by: wep21 <[email protected]>

* [autowarefoundation#1272] Add AckermannControlCommand support to simple_planning_simulator

* [autowarefoundation#1058] Add Longitudinal Controller node

* [autowarefoundation#1058] Rename velocity_controller -> longitudinal_controller

* [autowarefoundation#1058] Update CMakeLists.txt for the longitudinal_controller_node

* [autowarefoundation#1058] Add smoke test python launch file

* [autowarefoundation#1058] Use LowPassFilter1d from trajectory_follower

* [autowarefoundation#1058] Use autoware_auto_msgs

* [autowarefoundation#1058] Changes for .auto (debug msg tmp fix, common func, tf listener)

* [autowarefoundation#1058] Remove unused parameters

* [autowarefoundation#1058] Fix ros test

* [autowarefoundation#1058] Rm default params from declare_parameters + use autoware types

* [autowarefoundation#1058] Use default param file to setup NodeOptions in the ros test

* [autowarefoundation#1058] Fix docstring

* [autowarefoundation#1058] Replace receiving a Twist with a VehicleKinematicState

* [autowarefoundation#1058] Change class variables format to m_ prefix

* [autowarefoundation#1058] Fix plugin name of LongitudinalController in CMakeLists.txt

* [autowarefoundation#1058] Fix copyright dates

* [autowarefoundation#1058] Reorder includes

* [autowarefoundation#1058] Add some tests (~89% coverage without disabling flaky tests)

* [autowarefoundation#1058] Add more tests (90+% coverage without disabling flaky tests)

* [autowarefoundation#1058] Use Float32MultiArrayDiagnostic message for debug and slope

* [autowarefoundation#1058] Calculate wheel_base value from vehicle parameters

* [autowarefoundation#1058] Cleanup redundant logger setting in tests

* [autowarefoundation#1058] Set ROS_DOMAIN_ID when running tests to prevent CI failures

* [autowarefoundation#1058] Remove TF listener and use published vehicle state instead

* [autowarefoundation#1058] Change smoke tests to use autoware_testing

* [autowarefoundation#1058] Add plotjuggler cfg for both lateral and longitudinal control

* [autowarefoundation#1058] Improve design documents

* [autowarefoundation#1058] Disable flaky test

* [autowarefoundation#1058] Properly transform vehicle state in longitudinal node

* [autowarefoundation#1058] Fix TF buffer of lateral controller

* [autowarefoundation#1058] Tuning of lateral controller for LGSVL

* [autowarefoundation#1058] Fix formating

* [autowarefoundation#1058] Fix /tf_static sub to be transient_local

* [autowarefoundation#1058] Fix yaw recalculation of reverse trajs in the lateral controller

* modify trajectory_follower for galactic build

Signed-off-by: Takamasa Horibe <[email protected]>

* [autowarefoundation#1379] Update trajectory_follower

* [autowarefoundation#1379] Update simple_planning_simulator

* [autowarefoundation#1379] Update trajectory_follower_nodes

* apply trajectory msg modification in control

Signed-off-by: Takamasa Horibe <[email protected]>

* move directory

Signed-off-by: Takamasa Horibe <[email protected]>

* remote control/trajectory_follower level dorectpry

Signed-off-by: Takamasa Horibe <[email protected]>

* remove .iv trajectory follower

Signed-off-by: Takamasa Horibe <[email protected]>

* use .auto trajectory_follower

Signed-off-by: Takamasa Horibe <[email protected]>

* remove .iv simple_planning_simulator & osqp_interface

Signed-off-by: Takamasa Horibe <[email protected]>

* use .iv simple_planning_simulator & osqp_interface

Signed-off-by: Takamasa Horibe <[email protected]>

* add tmp_autoware_auto_dependencies

Signed-off-by: Takamasa Horibe <[email protected]>

* tmporally add autoware_auto_msgs

Signed-off-by: Takamasa Horibe <[email protected]>

* apply .auto message split

Signed-off-by: Takamasa Horibe <[email protected]>

* fix build depend

Signed-off-by: Takamasa Horibe <[email protected]>

* fix packages using osqp

* fix autoware_auto_geometry

* ignore lint of some packages

* ignore ament_lint of some packages

* ignore lint/pre-commit of trajectory_follower_nodes

* disable unit tests of some packages

Co-authored-by: Maxime CLEMENT <[email protected]>
Co-authored-by: Joshua Whitley <[email protected]>
Co-authored-by: Igor Bogoslavskyi <[email protected]>
Co-authored-by: MIURA Yasuyuki <[email protected]>
Co-authored-by: wep21 <[email protected]>
Co-authored-by: tomoya.kimura <[email protected]>

* [planning module]fix bug (autowarefoundation#643)

* fix topic name

* remove angular z from LinearInterpolation in motion_velocity_smoother

* fix readme

* ci(pre-commit): autofix

Co-authored-by: mitsudome-r <[email protected]>
Co-authored-by: Taichi Higashide <[email protected]>
Co-authored-by: Satoshi Tanaka <[email protected]>
Co-authored-by: Kosuke Murakami <[email protected]>
Co-authored-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Nikolai Morin <[email protected]>
Co-authored-by: Servando <[email protected]>
Co-authored-by: Esteve Fernandez <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Takagi, Isamu <[email protected]>
Co-authored-by: Kazuki Miyahara <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: Makoto Tokunaga <[email protected]>
Co-authored-by: Adam Dąbrowski <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: Keisuke Shima <[email protected]>
Co-authored-by: shin <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
Co-authored-by: Yukihiro Saito <[email protected]>
Co-authored-by: Hiroki OTA <[email protected]>
Co-authored-by: Takayuki Murooka <[email protected]>
Co-authored-by: Keisuke Shima <[email protected]>
Co-authored-by: Makoto Kurihara <[email protected]>
Co-authored-by: Satoshi OTA <[email protected]>
Co-authored-by: satoshi-ota <[email protected]>
Co-authored-by: Takayuki Murooka <[email protected]>
Co-authored-by: taikitanaka3 <[email protected]>
Co-authored-by: Maxime CLEMENT <[email protected]>
Co-authored-by: Joshua Whitley <[email protected]>
Co-authored-by: Igor Bogoslavskyi <[email protected]>
Co-authored-by: MIURA Yasuyuki <[email protected]>
Co-authored-by: wep21 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@BonoloAWF BonoloAWF added the type:new-feature New functionalities or additions, feature requests. label Apr 19, 2022
@mitsudome-r mitsudome-r added the component:tools Utility and debugging software. (auto-assigned) label Apr 19, 2022
@h-ohta h-ohta added the status:help-wanted Assistance or contributors needed. label May 16, 2022
@stale
Copy link

stale bot commented Jul 15, 2022

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jul 15, 2022
soblin pushed a commit to soblin/autoware.universe that referenced this issue Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:tools Utility and debugging software. (auto-assigned) status:help-wanted Assistance or contributors needed. status:stale Inactive or outdated issues. (auto-assigned) type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Development

No branches or pull requests

4 participants