Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(start_planner): add option for lane departure #4151

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jul 3, 2023

Description

add option for lane departure

this PR deal with the issue that the path from the current pose is out of lane so backward driving unnaturally

image

Related links

Tests performed

psim

image

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jul 3, 2023
@kosuke55 kosuke55 force-pushed the feat/lane_departure_option branch from 33efa6f to 45f0ef0 Compare July 3, 2023 10:03
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (f6e1e36) 14.30% compared to head (45f0ef0) 14.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4151      +/-   ##
==========================================
- Coverage   14.30%   14.30%   -0.01%     
==========================================
  Files        1571     1571              
  Lines      108342   108345       +3     
  Branches    31359    31361       +2     
==========================================
  Hits        15497    15497              
- Misses      75997    75999       +2     
- Partials    16848    16849       +1     
Flag Coverage Δ *Carryforward flag
differential 13.47% <0.00%> (?)
total 14.30% <ø> (+<0.01%) ⬆️ Carriedforward from f6e1e36

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...r/utils/start_planner/start_planner_parameters.hpp 0.00% <ø> (ø)
...planner/src/scene_module/start_planner/manager.cpp 13.33% <0.00%> (-0.46%) ⬇️
...planner/src/utils/start_planner/shift_pull_out.cpp 2.91% <0.00%> (-0.05%) ⬇️
.../src/fault_injection_node/fault_injection_node.cpp 36.53% <ø> (+0.68%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 merged commit 56b9ed8 into main Jul 3, 2023
@kosuke55 kosuke55 deleted the feat/lane_departure_option branch July 3, 2023 11:46
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jul 3, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jul 3, 2023
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Jul 3, 2023
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 28, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
kosuke55 added a commit to kosuke55/autoware.universe that referenced this pull request Sep 12, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants