Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pid_longitudinal_controller): re-organize diff limit structure #1052

Merged

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Jul 4, 2024

Description

launch side PR corresponds to a universe PR autowarefoundation/autoware.universe#7720

Tests performed

see universe PR

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:system System design and integration. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Jul 4, 2024
@yuki-takagi-66 yuki-takagi-66 changed the title Pid long fix diff limit structure feat(pid_longitudinal_controller): re-organize diff limit structure and fix state change condition Jul 4, 2024
@yuki-takagi-66 yuki-takagi-66 changed the title feat(pid_longitudinal_controller): re-organize diff limit structure and fix state change condition feat(pid_longitudinal_controller): re-organize diff limit structure Jul 4, 2024
@yuki-takagi-66 yuki-takagi-66 force-pushed the pid_long-fix-diff-limit-structure branch 2 times, most recently from a0bb4d5 to f9405be Compare July 19, 2024 10:24
@github-actions github-actions bot removed component:system System design and integration. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Jul 19, 2024
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review July 19, 2024 10:31
@yuki-takagi-66 yuki-takagi-66 force-pushed the pid_long-fix-diff-limit-structure branch from f9405be to aee38c7 Compare July 22, 2024 05:07
@github-actions github-actions bot added component:system System design and integration. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Jul 22, 2024
@yuki-takagi-66 yuki-takagi-66 force-pushed the pid_long-fix-diff-limit-structure branch from aee38c7 to 6353631 Compare July 22, 2024 05:24
@yuki-takagi-66 yuki-takagi-66 force-pushed the pid_long-fix-diff-limit-structure branch from 6353631 to dcbb8d7 Compare July 23, 2024 04:11
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
@yuki-takagi-66 yuki-takagi-66 force-pushed the pid_long-fix-diff-limit-structure branch from b0344bb to 75f28ba Compare July 24, 2024 02:28
@github-actions github-actions bot removed component:system System design and integration. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Jul 24, 2024
@yuki-takagi-66 yuki-takagi-66 merged commit b99303c into autowarefoundation:main Jul 24, 2024
13 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the pid_long-fix-diff-limit-structure branch July 24, 2024 04:53
yuki-takagi-66 added a commit to tier4/autoware_launch that referenced this pull request Aug 15, 2024
rej55 added a commit to tier4/autoware_launch that referenced this pull request Aug 15, 2024
feat(pid_longitudinal_controller): re-organize diff limit structure autowarefoundation#1052
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants